Skip modprobe in peermem container when module is already loaded#683
Merged
karthikvetrivel merged 1 commit intomainfrom Apr 10, 2026
Merged
Skip modprobe in peermem container when module is already loaded#683karthikvetrivel merged 1 commit intomainfrom
karthikvetrivel merged 1 commit intomainfrom
Conversation
tariq1890
reviewed
Apr 3, 2026
tariq1890
approved these changes
Apr 7, 2026
Contributor
tariq1890
left a comment
tariq1890
left a comment
There was a problem hiding this comment.
Thanks @karthikvetrivel ! Let's get one more approve before merging
Contributor
|
This LGTM. |
JunAr7112
approved these changes
Apr 8, 2026
Contributor
|
Do we also need to make this change in the |
Signed-off-by: Karthik Vetrivel <kvetrivel@nvidia.com>
karthikvetrivel
force-pushed
the
fix/peermem-fast-path-skip-modprobe
branch
from
26ab94a to
446061a
Compare
Member
Author
Good catch @cdesiniotis, fixed. |
cdesiniotis
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a driver pod is deleted and recreated, the fast-path optimization skips kernel module compilation/installation
since modules are already loaded in memory. However, the peermem sidecar unconditionally runs
chroot /run/nvidia/driver modprobe nvidia-peermem, which fails because/lib/modules/<kernel>/has no.kofiles on the fast path.Fix
Add an early check for /sys/module/nvidia_peermem/refcnt in reload_nvidia_peermem() before attempting modprobe. This mirrors the pattern used in nvidia-validator's
isNvidiaModuleLoaded().Test plan