Skip to content

Conversation

SethSmucker
Copy link
Collaborator

Add CompressionAlgorithm abstract class, used to implement modular compression algo classes.

Created example GZipCompression : CompressionAlgorithm as an example.

Added tests for them, although I'm not entirely sure all of the edge cases are covered. These are just what I could find online for GZIP.

Still needs to be implemented in actual classes that use compression.

This is just a proof of concept for feedback.

Comment on lines +208 to +211
Multimap<String,Type<?>> nonIndexedQueryFieldsDatatypes = HashMultimap.create(config.getQueryFieldsDatatypes());
nonIndexedQueryFieldsDatatypes.keySet().removeAll(config.getIndexedFields());
String nonIndexedTypes = QueryOptions.buildFieldNormalizerString(nonIndexedQueryFieldsDatatypes);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more extra to remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants