Design, practices and experience improvements

[antoinekm]

Hi there,
I came across your site, and I would like to give you some feedback on my user experience:

1. Design

• Upgrade to USWDS v2 #46
• The Hero's Call To Action doesn't have a distinctive color
• The background of the hero leaves something to be desired
• Improve footer logo quality #47

2. Bad practices

• Improve background image size and format #41
• Fix image link from nsa-insignia-lg http to https #43
• You should reduce the size of the dom and put less elements in it by using pagination for example to avoid long loadings which degrade the performances
• The site doesn't use any caching method, it could be interesting to use a third party like Cloudflare to improve the performance

3. Experience

• Sort repo list and use github api #49
• Fix footer terms of use and privacy links #44

[ctubbsii]

@antoinekm Thanks for the feedback. I think we could probably implement some of the proposed changes, but it may take some time.

[antoinekm]

A big upgrade to USWDS v2 could be a huge improvement too!

[ctubbsii]

@antoinekm I see you created many separate issues, and then submitted a PR for some of them. Please note that on GitHub, PRs already serve as their own issue, so there is no need to create a separate issue... they seem to appear as spam. PRs can easily reference this one issue that has already been created.

[antoinekm]

Hi @ctubbsii, ok, no worries, it would be nice to put the way you work in a CONTRIBUTING.md file to avoid this kind of misunderstanding ! 😅

[ctubbsii]

@antoinekm Thank you for the suggestion. I have been considering putting together a CONTRIBUTING guide for awhile now, but it is low on the priority list. Likewise, I would kindly suggest it might be a good idea to ask a project (such as on the conversation thread of the first ticket you created) before beginning a surge of contributions, as the project might not be prepared to handle the influx in the way you're doing it. But, you're right... if we want contributions done in a particular way, we should work to communicate that... thank you for that feedback. It is genuinely appreciated.