Skip to content

Add method to change notification sound #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 6, 2025
Merged

Add method to change notification sound #33

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
80bc9dc
Add silent and sound property and method to Notification class
Oct 24, 2025
8344b37
feat: implement local sound playback for notifications
Oct 27, 2025
e2d0057
Remove Error Catching Just Fail Silently
Oct 28, 2025
ec11f60
Remove Factory
Oct 28, 2025
02f3cce
Catch any error to make sure it fails silently
Oct 28, 2025
8088777
Changed player to just an import
Oct 28, 2025
34af4e9
Removed over complicated function
Oct 28, 2025
a00afd4
Build the js file
Oct 28, 2025
e646a57
Remove file:// and add automatic detecting of local files.
Oct 28, 2025
87946da
Add file checking before running playSoundLib().play and remove platf…
Oct 29, 2025
48406b2
Remove redundant if case
Oct 29, 2025
8ab48e6
Add not silent check to play audio
Oct 29, 2025
983ae06
Build new electron version
Oct 29, 2025
3df67c5
Merge branch 'main' into Add-method-to-change-notification-sound
simonhamp Nov 1, 2025
a1d7656
Add error logging for missing sound files in notifications
Nov 5, 2025
97bd0ae
Merge remote-tracking branch 'origin/main' into pr/Jianbe-03/33
gwleuverink Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Facades/Notification.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
/**
* @method static static title(string $title)
* @method static static event(string $event)
* @method static static sound(string $sound)
* @method static static silent(bool $silent = true)
* @method static static message(string $body)
* @method static static reference(string $reference)
* @method static static hasReply(string $placeholder = '')
Expand Down
20 changes: 20 additions & 0 deletions src/Notification.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ class Notification

protected string $event = '';

protected string $sound = '';

protected bool $silent = false;

private bool $hasReply = false;

private string $replyPlaceholder = '';
Expand Down Expand Up @@ -51,6 +55,20 @@ public function event(string $event): self
return $this;
}

public function sound(string $sound): self
{
$this->sound = $sound;

return $this;
}

public function silent(bool $silent = true): self
{
$this->silent = $silent;

return $this;
}

public function hasReply(string $placeholder = ''): self
{
$this->hasReply = true;
Expand Down Expand Up @@ -80,6 +98,8 @@ public function show(): self
'title' => $this->title,
'body' => $this->body,
'event' => $this->event,
'sound' => $this->sound,
'silent' => $this->silent,
'hasReply' => $this->hasReply,
'replyPlaceholder' => $this->replyPlaceholder,
'actions' => array_map(fn (string $label) => [
Expand Down
Loading