fix: memory leak on saving code cache

edusperoni · edusperoni · commit 6d416a11e5b3 · 2023-06-28T13:50:12.000-03:00
diff --git a/test-app/runtime/src/main/cpp/ModuleInternal.cpp b/test-app/runtime/src/main/cpp/ModuleInternal.cpp
@@ -507,6 +507,7 @@ void ModuleInternal::SaveScriptCache(const Local<Script> script, const std::stri
     int length = cachedData->length;
     auto cachePath = path + ".cache";
     File::WriteBinary(cachePath, cachedData->data, length);
+    delete cachedData;
 }
 
 ModuleInternal::ModulePathKind ModuleInternal::GetModulePathKind(const std::string& path) {

Original file line number	Diff line number	Diff line change
`@@ -507,6 +507,7 @@ void ModuleInternal::SaveScriptCache(const Local<Script> script, const std::stri`
`507`	`507`	`int length = cachedData->length;`
`508`	`508`	`auto cachePath = path + ".cache";`
`509`	`509`	`File::WriteBinary(cachePath, cachedData->data, length);`
	`510`	`+ delete cachedData;`
`510`	`511`	`}`
`511`	`512`
`512`	`513`	`ModuleInternal::ModulePathKind ModuleInternal::GetModulePathKind(const std::string& path) {`