Deployment scripts changes for localnet testing in fast-bridge-service #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UrAvgDeveloper
changed the title
UrAvgDeveloper
changed the title
UrAvgDeveloper
changed the title
olga24912
requested changes
Mar 27, 2023
eth/hardhat.config.js
Outdated
| task("get_block_hash", "returns the block hash of input block number") | ||
| .addParam("blocknumber", "Block number in integer") | ||
| .setAction(async (taskArgs) => { | ||
| const { getBlockHash } = require("./scripts/deployment/deploy_bridge_ETH.js"); |
There was a problem hiding this comment.
Better rename deploy_bridge_Eth.js to something like deploy_fastbridge_and_token.js
There was a problem hiding this comment.
Updated in 1436fac
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
For what do we need this file?
There was a problem hiding this comment.
Fixed in 1436fac
UrAvgDeveloper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hardhat task to help in localnet integration testing.
The task is: