Added Hardhat tasks for FastBridge solidity #92
Conversation
UrAvgDeveloper
changed the title
…ved code redundancy
UrAvgDeveloper
changed the title
UrAvgDeveloper
changed the title
UrAvgDeveloper
changed the title
| true, | ||
| true | ||
| ] | ||
| 1. To call any method of EthErc20FastBridge use hardhat task `method` |
There was a problem hiding this comment.
I suggest removing this generic task and creating separate hardhat tasks for each contract method.
There was a problem hiding this comment.
I have implemented separate tasks for each contract method in this PR, just not removed this generic function which could work as add-on functionality. Please let me know if you differ from this thought. I can remove the generic task.
There was a problem hiding this comment.
The implementation for methods transferTokens and withdrawStuckTokens is missed. This tasks also can be useful for debugging.
I prefer to remove the generic method, but it is up to you.
README.md
Outdated
| npx hardhat whitelists_token_in_bulk --tokenaddresses 0xF0b0c5E2c3A35213992bD9b45Af352D6D4035203,0xaa2D6608241B6B930BCcaFE245eFDf052e46C9aA --whiteliststatus true,true,true --network mumbai | ||
| ``` | ||
| Here also signer need to have the access role to make txn successful. | ||
| 6. To check whether the token is whitelisted or not run `npx hardhat is_token_whitelisted --tokenaddress <token_address> --network <network_name>` |
There was a problem hiding this comment.
It would be nice to have an opportunity to set up the address of the fast bridge contract
There was a problem hiding this comment.
added in cad08e9
README.md
Outdated
| npx hardhat method --jsonstring '{"signature":"setWhitelistedTokens","arguments":{"arg1":["0xdAC17F958D2ee523a2206206994597C13D831ec7"],"arg2":[true]}}' | ||
| ``` | ||
| 2. To deploy fast-bridge run `npx hardhat deploy_fastbridge --verification <bool> --network <network_name>` , here `--verification` is an optional parameter with default value `false` if passed `true` than contract is verified just after the deployment. |
There was a problem hiding this comment.
Could you write commands in the separate code block, not as inline code? It will be much easier to read.
4 participants
This PR resolves following issue: Issue
NOTE:
--verification <bool>is to verify the contract on the network just after the deployment. It's optional and default value isfalse.