test: include test vector submodule and runner for execution proofs and lc blocks #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mainly just did this to verify another implementation against this to make sure it matched up, but I figured I'd PR in for the case that you share the opinion that having a shared test suite for different clients is valuable. Feel free to just close this PR if not interested.
If open to this, let me know if this runner is set up how you'd like, and also if you'd want to transfer ownership of the test vector repo (I don't care to have it under my domain if you'd prefer).
Block test vectors are a bit slow, if you want to consider not having this run with the normal test suite. Approval message signature validation was prohibitively slow, so I just skipped that validation in the runner.
Link to test vector repo for convenience https://github.com/austinabell/near-light-client-tests