-
Notifications
You must be signed in to change notification settings - Fork 4.9k
feat(weapp): add props for weapp button #17947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(weapp): add props for weapp button #17947
Conversation
Walkthrough本次变更主要为 Button 组件增加了“手机号一键登录”相关的事件处理属性,包括类型定义和组件属性声明,适用于微信小程序平台。 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Button
participant App
User->>Button: 点击 open-type="phoneOneClickLogin" 按钮
Button->>App: 触发 onPhoneOneClickLogin 回调
App-->>User: 处理一键登录逻辑
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/taro-components/types/Button.d.ts
(1 hunks)packages/taro-platform-weapp/src/components.ts
(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/taro-components/types/Button.d.ts (1)
packages/taro-components/types/common.d.ts (1)
CommonEventFunction
(93-93)
🔇 Additional comments (1)
packages/taro-components/types/Button.d.ts (1)
286-290
: 确认支持 open-type="phoneOneClickLogin
经微信官方文档验证,Button 组件原生支持 open-type="phoneOneClickLogin" 实现本机号码一键登录功能,无需在类型声明中做额外修改。
这个 PR 做了什么? (简要描述所做更改)
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
Summary by CodeRabbit