fix: allow unlocking existing security_account resources
#500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acch
requested review from
carchi8py,
chuyich,
suhasbshekar and
wenjun666
as code owners
acch
force-pushed
the
499-security-account-locked
branch
from
f990d5f to
65e343a
Compare
…citly setting it to false Signed-off-by: Achim Christ <achim.christ@sva.de>
Signed-off-by: Achim Christ <achim.christ@sva.de>
Signed-off-by: Achim Christ <achim.christ@sva.de>
acch
force-pushed
the
499-security-account-locked
branch
from
65e343a to
6f631cd
Compare
csahu9
reviewed
May 29, 2025
suhasbshekar
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #499.
When unlocking existing, locked security accounts, Terraform produces the following error:
This PR changes the internal data type of the
lockedattribute to bool pointer, to allow for three distinct values:ACC tests pass:
$ TF_ACC=1 go test ./internal/provider/security/security_account_resource_test.go -v === RUN TestAccSecurityAccountResource --- PASS: TestAccSecurityAccountResource (7.98s) PASS ok command-line-arguments 7.988s