added a KASSERT, just to be sure.

dettus · dettus · commit 714aed1a4fb5 · 2025-03-04T07:05:46.000+01:00
diff --git a/sys/external/bsd/drm2/dist/drm/i915/gt/intel_ggtt.c b/sys/external/bsd/drm2/dist/drm/i915/gt/intel_ggtt.c
@@ -282,12 +282,13 @@ static void gen8_ggtt_insert_entries(struct i915_address_space *vm,
 			gen8_set_pte(ggtt->gsmt, ggtt->gsmh, pgno++,
 			    pte_encode | addr);
 		}
+		KASSERT(len == 0);
 		/* Fill the allocated but "unused" space beyond the end of the buffer */
-		for (;pgno<pgend;pgno++,len--)
+		KASSERT(pgno <= pgend);
+		for (;pgno<pgend;pgno++)
 		{
 			gen8_set_pte(ggtt->gsmt + pgno, vm->scratch[0].encode);
 		}
-		KASSERT(len == 0);
 	}
 #else
 	gte = (gen8_pte_t __iomem *)ggtt->gsm;

Original file line number	Diff line number	Diff line change
`@@ -282,12 +282,13 @@ static void gen8_ggtt_insert_entries(struct i915_address_space *vm,`
`282`	`282`	`gen8_set_pte(ggtt->gsmt, ggtt->gsmh, pgno++,`
`283`	`283`	`pte_encode \| addr);`
`284`	`284`	`}`
	`285`	`+ KASSERT(len == 0);`
`285`	`286`	`/* Fill the allocated but "unused" space beyond the end of the buffer */`
`286`		`- for (;pgno<pgend;pgno++,len--)`
	`287`	`+ KASSERT(pgno <= pgend);`
	`288`	`+ for (;pgno<pgend;pgno++)`
`287`	`289`	`{`
`288`	`290`	`gen8_set_pte(ggtt->gsmt + pgno, vm->scratch[0].encode);`
`289`	`291`	`}`
`290`		`- KASSERT(len == 0);`
`291`	`292`	`}`
`292`	`293`	`#else`
`293`	`294`	`gte = (gen8_pte_t __iomem *)ggtt->gsm;`