Skip to content

fix(config): Update clientlibs and renderClientLibs to read extraEntries correctly #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(config): Update clientlibs and renderClientLibs to read extraEntries correctly #131

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc56e9c
fix(config): Update clientlibs and renderClientLibs to read extraEntr…
albertogarciaariza May 15, 2025
f5e6f9f
refactor(config): Allow multiple extraEntries in config.clientlibs
May 19, 2025
409944b
refactor(utils): Remove autoprefixer test from console log when runni…
May 19, 2025
bca3664
test(utils): Remove extra files created
May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tasks/clientlibs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const renderClientLibs = require('../utils/renderClientLibs');
module.exports = (config) => {
log(__filename, 'clientlibs task running...', '', 'info');

const { extraEntries } = config.postcss;
const { extraEntries } = config.clientlibs;

// checking all entries at this configuration
let entries = {
Expand Down
2 changes: 1 addition & 1 deletion utils/renderClientLibs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ module.exports = function renderClientLibs(clientLibObject, config) {
writeFile(path.join(absolutePath, 'js.txt'), `${js}`, override);
}

const extensionFile = config.postcss.extraEntries?.extension;
const extensionFile = config.clientlibs.extraEntries?.extension;
const hasExtraEntries = extensionFile && clientLibObject[extensionFile];
const fileName = clientLibObject[extensionFile];
if ( hasExtraEntries ) {
Expand Down