From f6b8b97e171243cc2a15d36cb087dc7de2793e19 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:40 -0400 Subject: [PATCH 01/16] spelling: actual Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- spinnaker/fromjson_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spinnaker/fromjson_test.go b/spinnaker/fromjson_test.go index 9d8cae7..c1869bb 100644 --- a/spinnaker/fromjson_test.go +++ b/spinnaker/fromjson_test.go @@ -58,7 +58,7 @@ func TestFromJSON(t *testing.T) { } if actual.MeanTimeBetweenKillsInWorkDays != 5 { - t.Errorf("Expected mean time: 5. acutal mean time: %d", actual.MeanTimeBetweenKillsInWorkDays) + t.Errorf("Expected mean time: 5. actual mean time: %d", actual.MeanTimeBetweenKillsInWorkDays) } if !actual.RegionsAreIndependent { From 5bb5f7ca57f52b5e304798f11c857b405ff23961 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:41 -0400 Subject: [PATCH 02/16] spelling: automatically Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- docs/plugins/Outage-checker.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/plugins/Outage-checker.md b/docs/plugins/Outage-checker.md index 7bfe5fd..43f398d 100644 --- a/docs/plugins/Outage-checker.md +++ b/docs/plugins/Outage-checker.md @@ -1,4 +1,4 @@ -An outage checker is used to automatially disable Chaos Monkey during ongoing outages. +An outage checker is used to automatically disable Chaos Monkey during ongoing outages. If you wish to have Chaos Monkey check if there is an ongoing outage and disable accordingly, you need to: From 297127a11f486435e9a42599ae42b1f436c40fa8 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:41 -0400 Subject: [PATCH 03/16] spelling: behavior Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- mkdocs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkdocs.yml b/mkdocs.yml index f7aafd4..a862406 100644 --- a/mkdocs.yml +++ b/mkdocs.yml @@ -8,7 +8,7 @@ pages: - How to deploy: How-to-deploy.md - Configuration file format: Configuration-file-format.md - Configuring behavior via Spinnaker: Configuring-behavior-via-spinnaker.md - - Termination behaior: Termination-behavior.md + - Termination behavior: Termination-behavior.md - Running locally: Running-locally.md - Plugins: - Home: plugins/index.md From aa71986c54a209b93008018429bcb8ab06e09325 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:42 -0400 Subject: [PATCH 04/16] spelling: canonical Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- migration/migrations.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/migration/migrations.go b/migration/migrations.go index b37e6e8..d9c1dc9 100644 --- a/migration/migrations.go +++ b/migration/migrations.go @@ -92,8 +92,8 @@ func migrationMysql100_initial_schemaSql() (*asset, error) { // It returns an error if the asset could not be found or // could not be loaded. func Asset(name string) ([]byte, error) { - cannonicalName := strings.Replace(name, "\\", "/", -1) - if f, ok := _bindata[cannonicalName]; ok { + canonicalName := strings.Replace(name, "\\", "/", -1) + if f, ok := _bindata[canonicalName]; ok { a, err := f() if err != nil { return nil, fmt.Errorf("Asset %s can't read by error: %v", name, err) @@ -118,8 +118,8 @@ func MustAsset(name string) []byte { // It returns an error if the asset could not be found or // could not be loaded. func AssetInfo(name string) (os.FileInfo, error) { - cannonicalName := strings.Replace(name, "\\", "/", -1) - if f, ok := _bindata[cannonicalName]; ok { + canonicalName := strings.Replace(name, "\\", "/", -1) + if f, ok := _bindata[canonicalName]; ok { a, err := f() if err != nil { return nil, fmt.Errorf("AssetInfo %s can't read by error: %v", name, err) @@ -159,8 +159,8 @@ var _bindata = map[string]func() (*asset, error){ func AssetDir(name string) ([]string, error) { node := _bintree if len(name) != 0 { - cannonicalName := strings.Replace(name, "\\", "/", -1) - pathList := strings.Split(cannonicalName, "/") + canonicalName := strings.Replace(name, "\\", "/", -1) + pathList := strings.Split(canonicalName, "/") for _, p := range pathList { node = node.Children[p] if node == nil { @@ -234,6 +234,6 @@ func RestoreAssets(dir, name string) error { } func _filePath(dir, name string) string { - cannonicalName := strings.Replace(name, "\\", "/", -1) - return filepath.Join(append([]string{dir}, strings.Split(cannonicalName, "/")...)...) + canonicalName := strings.Replace(name, "\\", "/", -1) + return filepath.Join(append([]string{dir}, strings.Split(canonicalName, "/")...)...) } From 04c18e0b72df5a7a2a61116e26c0c5c6259ac688 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:43 -0400 Subject: [PATCH 05/16] spelling: chaos Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- config/monkey.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/monkey.go b/config/monkey.go index e3c9aff..c9a2354 100644 --- a/config/monkey.go +++ b/config/monkey.go @@ -235,7 +235,7 @@ func (m *Monkey) AccountEnabled(account string) (bool, error) { return false, nil } -// Accounts return a list of accounts where Choas Monkey is enabled +// Accounts return a list of accounts where Chaos Monkey is enabled func (m *Monkey) Accounts() ([]string, error) { err := m.readRemoteConfig() if err != nil { From 72d87d5da8d12f85842396c4e15d58a806751335 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:43 -0400 Subject: [PATCH 06/16] spelling: chaosmonkey Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- docs/plugins/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/plugins/index.md b/docs/plugins/index.md index c434410..5316858 100644 --- a/docs/plugins/index.md +++ b/docs/plugins/index.md @@ -41,7 +41,7 @@ See the [Constrainer](Constrainer) page for an example implementation. ### 3. Create the file that loads the plugins -File: `$GOPATH/src/example.com/chasmonkey/cmd/chaosmonkey/main.go` +File: `$GOPATH/src/example.com/chaosmonkey/cmd/chaosmonkey/main.go` It looks like this: From 918d965f81f62d9a2542298007d6cd94a6ec5d4d Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:44 -0400 Subject: [PATCH 07/16] spelling: clusters Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- chaosmonkey.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chaosmonkey.go b/chaosmonkey.go index e6af247..8d809db 100644 --- a/chaosmonkey.go +++ b/chaosmonkey.go @@ -51,7 +51,7 @@ type ( // Exception describes clusters that have been opted out of chaos monkey // If one of the members is a "*", it matches everything. That is the only // wildcard value - // For example, this will opt-out all of the cluters in the test account: + // For example, this will opt-out all of the clusters in the test account: // Exception{ Account:"test", Stack:"*", Cluster:"*", Region: "*"} Exception struct { Account string From 6c61774cbcf0fdbf761e96376366dfcfc5f91793 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 19:39:15 -0400 Subject: [PATCH 08/16] spelling: database Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- mysql/mysql_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mysql/mysql_test.go b/mysql/mysql_test.go index fc1d28e..acecf91 100644 --- a/mysql/mysql_test.go +++ b/mysql/mysql_test.go @@ -155,7 +155,7 @@ func startMySQLContainer() (*exec.Cmd, error) { } // initDB initializes the "chaosmonkey" database with the chaosmonkey schemas -// It wipes out any existing database database with the same name +// It wipes out any existing database with the same name func initDB() error { db, err := sql.Open("mysql", fmt.Sprintf("root:%s@tcp(127.0.0.1:%d)/", password, port)) if err != nil { From ec6089d5396d962630c534b85a670e2f9167e9e6 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:45 -0400 Subject: [PATCH 09/16] spelling: implementations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- config/monkey.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/monkey.go b/config/monkey.go index c9a2354..742681e 100644 --- a/config/monkey.go +++ b/config/monkey.go @@ -307,7 +307,7 @@ func (m *Monkey) Trackers() ([]string, error) { return m.getStringSlice(param.Trackers) } -// ErrorCounter returns the names of the backend implementions for +// ErrorCounter returns the names of the backend implementations for // error counters. Intended for monitoring/alerting. func (m *Monkey) ErrorCounter() string { return m.v.GetString(param.ErrorCounter) From adfb9c753ab80c0114b749348ce2d35b0997d3cf Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:45 -0400 Subject: [PATCH 10/16] spelling: implements Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- mock/outage.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mock/outage.go b/mock/outage.go index 646dffc..98c9c52 100644 --- a/mock/outage.go +++ b/mock/outage.go @@ -17,7 +17,7 @@ package mock // Outage is a mock implementation of outage.Outage type Outage struct{} -// Outage implemnets outage.Outage.Outage +// Outage implements outage.Outage.Outage func (o Outage) Outage() (bool, error) { return false, nil } From 16d9ec969eebe72b8d3b2abdfff0010dec4c6b4e Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:46 -0400 Subject: [PATCH 11/16] spelling: localhost Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- mysql/mysql_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mysql/mysql_test.go b/mysql/mysql_test.go index acecf91..5cba33c 100644 --- a/mysql/mysql_test.go +++ b/mysql/mysql_test.go @@ -48,7 +48,7 @@ var ( port int = 3306 ) -// inUse returns true if port accepts connections on localhsot +// inUse returns true if port accepts connections on localhost func inUse(port int) bool { conn, err := net.Dial("tcp", fmt.Sprintf("127.0.0.1:%d", port)) if err != nil { From f84aff4e9512e75d9b7a8033414cb33ca6413399 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:47 -0400 Subject: [PATCH 12/16] spelling: needed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- term/terminate_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/term/terminate_test.go b/term/terminate_test.go index 883b125..0ab0220 100644 --- a/term/terminate_test.go +++ b/term/terminate_test.go @@ -116,7 +116,7 @@ func TestTerminateDoesntKillInLeashedMode(t *testing.T) { deps := mockDeps() cfg := config.Defaults() // Setting leashed explicitly for code clarity, default is leashed so - // this isn't strictly neededj + // this isn't strictly needed cfg.Set(param.Leashed, true) deps.MonkeyCfg = cfg From a106f97ab82402c7d0f608906082be8c2bfcd484 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:47 -0400 Subject: [PATCH 13/16] spelling: nonexistent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- migration/migrations.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migrations.go b/migration/migrations.go index d9c1dc9..3d96e0a 100644 --- a/migration/migrations.go +++ b/migration/migrations.go @@ -154,7 +154,7 @@ var _bindata = map[string]func() (*asset, error){ // b.png // then AssetDir("data") would return []string{"foo.txt", "img"} // AssetDir("data/img") would return []string{"a.png", "b.png"} -// AssetDir("foo.txt") and AssetDir("notexist") would return an error +// AssetDir("foo.txt") and AssetDir("nonexistent") would return an error // AssetDir("") will return []string{"data"}. func AssetDir(name string) ([]string, error) { node := _bintree From 2f691ddf7a2028f4e0ce892ccf146f9839c8004e Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:48 -0400 Subject: [PATCH 14/16] spelling: returns Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- config/monkey.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/config/monkey.go b/config/monkey.go index 742681e..005d4cc 100644 --- a/config/monkey.go +++ b/config/monkey.go @@ -341,7 +341,7 @@ func (m *Monkey) SpinnakerEndpoint() string { return m.v.GetString(param.SpinnakerEndpoint) } -// SpinnakerCertificate retunrs a path to a .p12 file that contains a TLS cert +// SpinnakerCertificate returns a path to a .p12 file that contains a TLS cert // for authenticating against Spinnaker func (m *Monkey) SpinnakerCertificate() string { return m.v.GetString(param.SpinnakerCertificate) @@ -360,12 +360,12 @@ func (m *Monkey) SpinnakerUser() string { return m.v.GetString(param.SpinnakerUser) } -// SpinnakerX509Cert retunrs a path to a X509 cert file +// SpinnakerX509Cert returns a path to a X509 cert file func (m *Monkey) SpinnakerX509Cert() string { return m.v.GetString(param.SpinnakerX509Cert) } -// SpinnakerX509Key retunrs a path to a X509 key file +// SpinnakerX509Key returns a path to a X509 key file func (m *Monkey) SpinnakerX509Key() string { return m.v.GetString(param.SpinnakerX509Key) } From 766fdcc58cd4f9e10c1b73f77f0ed98278859f24 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:49 -0400 Subject: [PATCH 15/16] spelling: successes Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- mysql/checker_test.go | 2 +- mysql/schedstore_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mysql/checker_test.go b/mysql/checker_test.go index a7f709c..27d84ee 100644 --- a/mysql/checker_test.go +++ b/mysql/checker_test.go @@ -202,7 +202,7 @@ func TestConcurrentChecks(t *testing.T) { } if got, want := success, 1; got != want { - t.Errorf("got %d succeses, want: %d", got, want) + t.Errorf("got %d successes, want: %d", got, want) } } diff --git a/mysql/schedstore_test.go b/mysql/schedstore_test.go index 6cdc86a..a5b2593 100644 --- a/mysql/schedstore_test.go +++ b/mysql/schedstore_test.go @@ -244,7 +244,7 @@ func TestScheduleAlreadyExistsConcurrency(t *testing.T) { } if got, want := success, 1; got != want { - t.Errorf("got %d succeses, want: %d", got, want) + t.Errorf("got %d successes, want: %d", got, want) } // Should cause a deadlock From ef94ea2d6c4ec2d3ff5b8fec0aac4dc193c5d890 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 18 Jun 2023 20:01:49 -0400 Subject: [PATCH 16/16] spelling: unleashed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- term/terminate_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/term/terminate_test.go b/term/terminate_test.go index 0ab0220..86040e9 100644 --- a/term/terminate_test.go +++ b/term/terminate_test.go @@ -134,7 +134,7 @@ func TestTerminateDoesntKillInLeashedMode(t *testing.T) { } -// TestNeverTerminateInTestEnv checks that unleasshed terms are not allowed in +// TestNeverTerminateInTestEnv checks that unleashed terms are not allowed in // test func TestNeverTerminateUnleashedInTestEnv(t *testing.T) {