Optimize receipt canonicality with OnUpdateMainChain batching

[benaadams]

Changes

• Use OnUpdateMainChain event for batched tx-index writes instead of per-block EnsureCanonical calls, reducing write batch overhead during multi-block chain updates
• Fire OnUpdateMainChain before the per-block MoveToMain loop so tx indices are committed before NewCanonicalReceipts notifies JSON-RPC subscribers
• Extract ShouldIndexBlock and WriteCanonicalTxIndex helpers to share logic between single-block and batch paths
• Add IDisposable to PersistentReceiptStorage to unsubscribe both event handlers
• Use PutSpan instead of BytesToArray() for non-compact tx index writes to avoid allocation
• Add early return in RemoveBlockTx when block has no transactions
• Simplify BlockTree.UpdateMainChain ascending-order check and DEBUG validation loop

Types of changes

What types of changes does your code introduce?

• Optimization
• Refactoring

Testing

Requires testing

• Yes

If yes, did you write tests?

• Yes

[Copilot]

Pull request overview

This PR optimizes receipt canonicality updates during multi-block main-chain updates by propagating main-chain update batch metadata through BlockTree events and using that metadata to batch transaction-index writes in PersistentReceiptStorage.

Changes:

• Extend BlockReplacementEventArgs with main-chain update batching metadata (while preserving existing constructor call sites).
• Propagate batch metadata from BlockTree.UpdateMainChain / MoveToMain into BlockAddedToMain events.
• Batch canonical tx-index writes in PersistentReceiptStorage across a main-chain update (with bounded flushing and stale/out-of-order event hardening) and add targeted tests.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/Nethermind/Nethermind.Core/BlockReplacementEventArgs.cs	Adds batch metadata fields and new constructors for compatibility.
src/Nethermind/Nethermind.Core/BlockProcessingConstants.cs	Introduces shared constant for bounding uncommitted block processing/batching.
src/Nethermind/Nethermind.Consensus/Processing/BranchProcessor.cs	Reuses shared MaxUncommittedBlocks constant instead of a local copy.
src/Nethermind/Nethermind.Blockchain/Receipts/PersistentReceiptStorage.cs	Implements canonical tx-index batching keyed by main-chain update metadata; adds bounded flush + stale batch handling.
src/Nethermind/Nethermind.Blockchain/BlockTree.cs	Tags BlockAddedToMain events with update-batch metadata during multi-block UpdateMainChain.
src/Nethermind/Nethermind.Blockchain.Test/Receipts/PersistentReceiptStorageTests.cs	Adds tests covering commit-on-last behavior, batch-id changes, stale events, and max-batch flush.
src/Nethermind/Nethermind.Blockchain.Test/BlockTreeTests.cs	Adds tests validating batch metadata presence for multi-block updates and absence for single-block updates.
.gitignore	Ignores /.dotnet_cli.

Comments suppressed due to low confidence (1)

src/Nethermind/Nethermind.Blockchain/BlockTree.cs:978

• These 'if' statements can be combined.

            if (isBatchUpdate)
            {
                if (blocks[^1].Number < blocks[0].Number)
                {
                    ascendingOrder = false;
                }
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.