Ad ptr merge #1
Draft
Ad ptr merge #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeuralCoder3
commented
Oct 25, 2022
| @@ -29,6 +49,7 @@ add_thorin_dialect(clos | |||
| clos/phase/lower_typed_clos.cpp | |||
| clos/phase/lower_typed_clos.h | |||
| mem/passes/fp/copy_prop.cpp | |||
| mem/passes/rw/reshape.cpp | |||
There was a problem hiding this comment.
Check if inter-dialect phases are necessary here.
|
|
||
| auto cmp = core::op(core::icmp::ul, iter, end); | ||
| for_lam->branch(false, cmp, new_body, if_else, w.tuple()); | ||
| for_lam->branch(false, cmp, new_body, if_else, acc); |
There was a problem hiding this comment.
@christopherhjung
Is the inlining/forwarding of the accumulator necessary here?
Optimizations like CopyProp will probably delete the arguments.
And Closure Conversion has as one main function closing open terms and will (if not inlined) re-add the accumulator and bound variables as arguments.
leissa
reviewed
Oct 26, 2022
|
@christopherhjung Reshape has problems with empty arguments (or higher-order arguments). |
Pin the MacOS runner to MacOS 11.x, since the 12.x makes the download-release-asset action fail. Since I don't know much about Node.JS I opened an issue against the action's repo: i3h/download-release-asset#9
[CI] Downgrade MacOS Runner to 11 for now
…s remain for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review the changes and keep track of changes.