Skip to content

Make SpikeEventSeries.timestamps explicitly required #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2025
Merged

Make SpikeEventSeries.timestamps explicitly required #629

merged 5 commits into from
Jun 9, 2025

Conversation

rly
Copy link
Contributor

@rly rly commented May 16, 2025 •
edited
Loading

Summary of changes

Checklist

For all schema changes:

  • Add release notes for the PR to docs/format/source/format_release_notes.rst.
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.
  • Make sure that hdmf-common-schema points to the latest release and not the latest commit on the main branch.

@rly rly requested a review from stephprince June 9, 2025 20:30
rly
rly commented Jun 9, 2025
View reviewed changes
@rly rly merged commit 29bd1fd into dev Jun 9, 2025
4 checks passed
@rly rly deleted the ses_timestamps branch June 9, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephprince stephprince stephprince approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perceived(?) ambiguity w.r.t timestamps of SpikeEventSeries
2 participants
@rly @stephprince