From cf1307770a8659706c49e035c02fa67d54939413 Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Fri, 2 May 2025 16:35:44 -0700 Subject: [PATCH 1/3] Allow EventDetection` to store channel index --- core/nwb.ecephys.yaml | 15 ++++++++++----- docs/format/source/format_release_notes.rst | 1 + 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/core/nwb.ecephys.yaml b/core/nwb.ecephys.yaml index 87761626..8daf2dfd 100644 --- a/core/nwb.ecephys.yaml +++ b/core/nwb.ecephys.yaml @@ -161,12 +161,16 @@ groups: - name: source_idx dtype: int32 dims: - - num_events + - - num_events + - - num_events + - time_index, channel_index shape: - - null - doc: Indices (zero-based) into source ElectricalSeries::data array corresponding - to time of event. ''description'' should define what is meant by time of - event (e.g., .25 ms before action potential peak, zero-crossing time, etc). + - - null + - - null + - 2 + doc: Indices (zero-based) into the linked source ElectricalSeries::data array corresponding + to time of event or time and channel of event. ''description'' should define what is meant + by time of event (e.g., .25 ms before action potential peak, zero-crossing time, etc). The index points to each event from the raw data. - name: times dtype: float64 @@ -180,6 +184,7 @@ groups: dtype: text value: seconds doc: Unit of measurement for event times, which is fixed to 'seconds'. + quantity: '?' links: - name: source_electricalseries target_type: ElectricalSeries diff --git a/docs/format/source/format_release_notes.rst b/docs/format/source/format_release_notes.rst index 7904d441..1c22bd88 100644 --- a/docs/format/source/format_release_notes.rst +++ b/docs/format/source/format_release_notes.rst @@ -9,6 +9,7 @@ Release Notes Major changes ^^^^^^^^^^^^^ - Added `BaseImage` and `ExternalImage` as new neurodata types. The first so both `Image` and `ExternalImage` can inherit from it. The second to store external images (#604) +- Allowed `EventDetection` to have shape (num_events, 2) to store the channel index of the detected event. () Minor changes ^^^^^^^^^^^^^ From b6279af1e3334773ce26525a3f1d98005e2e7092 Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Fri, 2 May 2025 16:36:40 -0700 Subject: [PATCH 2/3] Update release notes --- docs/format/source/format_release_notes.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/format/source/format_release_notes.rst b/docs/format/source/format_release_notes.rst index 1c22bd88..fa41874c 100644 --- a/docs/format/source/format_release_notes.rst +++ b/docs/format/source/format_release_notes.rst @@ -9,7 +9,7 @@ Release Notes Major changes ^^^^^^^^^^^^^ - Added `BaseImage` and `ExternalImage` as new neurodata types. The first so both `Image` and `ExternalImage` can inherit from it. The second to store external images (#604) -- Allowed `EventDetection` to have shape (num_events, 2) to store the channel index of the detected event. () +- Allowed `EventDetection` to have shape (num_events, 2) to store the channel index of the detected event. (#620) Minor changes ^^^^^^^^^^^^^ From f59a73a44b642ae50c0a939f1bb7c2e0df14b3d1 Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Fri, 2 May 2025 16:38:03 -0700 Subject: [PATCH 3/3] Update format_release_notes.rst --- docs/format/source/format_release_notes.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/format/source/format_release_notes.rst b/docs/format/source/format_release_notes.rst index fa41874c..c3f426cb 100644 --- a/docs/format/source/format_release_notes.rst +++ b/docs/format/source/format_release_notes.rst @@ -15,6 +15,7 @@ Minor changes ^^^^^^^^^^^^^ - Made group quantities consistent ("1 or more") across data interfaces / wrapper types (#613) - Fixed typo and removed HTML tag from doc of behavioral neurodata types. (#600) +- Made `EventDetection.times` optional. (#620) 2.8.0 (November 24, 2024) -------------------------