Skip to content

Make SpikeEventSeries.timestamps explicitly required #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2025
Merged

Make SpikeEventSeries.timestamps explicitly required #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29a86b9
Make SpikeEventSeries.timestamps explicitly required
rly May 16, 2025
50dd9c4
Update format_release_notes.rst
rly May 16, 2025
9d979c2
Merge branch 'dev' into ses_timestamps
rly Jun 9, 2025
abca168
Update docs/format/source/format_release_notes.rst
rly Jun 9, 2025
e0fed21
Merge branch 'dev' into ses_timestamps
rly Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/nwb.ecephys.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ groups:
common experiment master-clock stored in NWBFile.timestamps_reference_time.
Timestamps are required for the events. Unlike for TimeSeries, timestamps are
required for SpikeEventSeries and are thus re-specified here.
quantity: 1
attributes:
- name: interval
dtype: int32
Expand Down
1 change: 1 addition & 0 deletions docs/format/source/format_release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Major changes
can inherit from it. The second to store external images (#604, #623, #627)
- Changed ``NWBFile.electrodes`` from a generic ``DynamicTable`` with added columns to a new ``ElectrodesTable``
neurodata type that extends ``DynamicTable`` with added columns. (#539, #624)
- Made ``SpikeEventSeries.timestamps`` explicitly required as described in the documentation. (#629)
- Changed ``DecompositionSeries.bands`` from a generic ``DynamicTable`` with added columns to a new ``FrequencyBandsTable`` neurodata type that extends ``DynamicTable`` with added columns. (#610)
- Allowed `EventDetection` to have shape (num_events, 2) to store the channel index of the detected event. (#620)

Expand Down