NWBHDF5IO: Don't check path if it is None #2130
Merged
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to check if the given path ends in .nwb if it is not None.
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2130 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 28 28
Lines 2849 2849
Branches 736 736
=======================================
Hits 2712 2712
Misses 83 83
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-b
added a commit
to AllenInstitute/ipfx
that referenced
this pull request
Aug 27, 2025
pynwb 3.1.2 does currently always output a warning about a missing .nwb ending in path even if path was not passed at all and is None. This will be fixed in [1], ignore the warning until we require that version. We also drop the path argument to NWBHDF5IO as that is not needed. [1]: NeurodataWithoutBorders/pynwb#2130
stephprince
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need to check if the given path ends in .nwb if it is not None.
Close #2125