Skip to content

Commit 5c02918

Browse files
committed
refactor(windows): adapted code for MSVC compatibility, fixed warnings
1 parent 1c2f5e8 commit 5c02918

24 files changed

+70
-26
lines changed

build-examples.bat

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
mkdir build
2+
cmake -S . -B build -DCMAKE_CXX_STANDARD=17 > log.txt 2>&1
3+
cmake --build build >> log.txt 2>&1
4+
pause

examples/example_logit_basic.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/// \file logging_example.cpp
22
/// \brief Demonstrates the usage of the LogIt library with various data types and scenarios.
33

4-
#define LOGIT_BASE_PATH "E:\\_repoz\\log-it-cpp"
4+
// #define LOGIT_BASE_PATH "E:\\_repoz\\log-it-cpp" <- задается через Cmake
55

66
#include <iostream>
77
#include <stdexcept>

examples/example_logit_custom_backend.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#define LOGIT_BASE_PATH "E:\\_repoz\\log-it-cpp"
1+
// #define LOGIT_BASE_PATH "E:\\_repoz\\log-it-cpp" <- задается через Cmake
22

33
#include <iostream>
44
#include <sstream>
@@ -30,16 +30,19 @@ class CustomLogger : public logit::ILogger {
3030
// Implementing other pure virtual methods
3131
std::string get_string_param(const logit::LoggerParam& param) const override {
3232
// Returning an empty string for this example, can be customized
33+
(void)param;
3334
return "";
3435
}
3536

3637
int64_t get_int_param(const logit::LoggerParam& param) const override {
3738
// Returning a default value, can be customized
39+
(void)param;
3840
return 0;
3941
}
4042

4143
double get_float_param(const logit::LoggerParam& param) const override {
4244
// Returning a default value, can be customized
45+
(void)param;
4346
return 0.0;
4447
}
4548

examples/example_logit_customized.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#define LOGIT_BASE_PATH "E:\\_repoz\\log-it-cpp"
1+
// #define LOGIT_BASE_PATH "E:\\_repoz\\log-it-cpp" <- задается через Cmake
22

33
// Customizing the logging settings
44
#define LOGIT_CONSOLE_PATTERN "%Y-%m-%d %H:%M:%S [%L] %v" // Custom pattern for console logs
@@ -12,11 +12,11 @@
1212

1313
// Example enumeration
1414
enum LogLevel {
15-
_DEBUG,
16-
_INFO,
17-
_WARN,
18-
_ERROR,
19-
_FATAL
15+
L_DEBUG,
16+
L_INFO,
17+
L_WARN,
18+
L_ERROR,
19+
L_FATAL
2020
};
2121

2222
int main() {
@@ -30,7 +30,7 @@ int main() {
3030
// Log various levels of messages
3131
float someFloat = 42.42f;
3232
int someInt = 100;
33-
LogLevel level = _INFO;
33+
LogLevel level = L_INFO;
3434

3535
LOGIT_INFO("Logging an informational message with customized settings", someFloat, someInt, level);
3636
LOGIT_WARN("Warning: Potential issue with customized log settings!");

examples/example_logit_short_macros.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#define LOGIT_BASE_PATH "E:\\_repoz\\log-it-cpp"
1+
// #define LOGIT_BASE_PATH "E:\\_repoz\\log-it-cpp" <- задается через Cmake
22
#define LOGIT_SHORT_NAME // Enable short macros
33

44
#include <iostream>

include/log-it/LogItConfig.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#pragma once
22
#ifndef _LOGIT_CONFIG_HPP_INCLUDED
33
#define _LOGIT_CONFIG_HPP_INCLUDED
4+
45
/// \file LogItConfig.hpp
56
/// \brief Configuration macros for the LogIt logging system.
67

include/log-it/parts/Formatter/ILogFormatter.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#pragma once
22
#ifndef _LOGIT_ILOG_FORMATTER_HPP_INCLUDED
33
#define _LOGIT_ILOG_FORMATTER_HPP_INCLUDED
4+
45
/// \file ILogFormatter.hpp
56
/// \brief Defines the interface for log formatters used in the logging system.
67

include/log-it/parts/Formatter/SimpleLogFormatter.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
#pragma once
22
#ifndef _LOGIT_SIMPLE_LOG_FORMATTER_HPP_INCLUDED
33
#define _LOGIT_SIMPLE_LOG_FORMATTER_HPP_INCLUDED
4+
45
/// \file SimpleLogFormatter.hpp
56
/// \brief Defines the SimpleLogFormatter class for formatting log messages according to a specified pattern or JSON format.
67

78
#include "ILogFormatter.hpp"
89
#include "SimpleLogFormatter/PatternCompiler.hpp"
10+
#include <time_shield/time_conversions.hpp>
911

1012
namespace logit {
1113

include/log-it/parts/Formatter/SimpleLogFormatter/PatternCompiler.hpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
/// \file PatternCompiler.hpp
66
/// \brief Header file for the pattern compiler used in log formatting.
77

8-
#include <time_shield.hpp>
8+
#include <time_shield/time_conversions.hpp>
99
#include <vector>
1010
#include <string>
1111
#include <sstream>
@@ -366,7 +366,7 @@ namespace logit {
366366
// Keep portions of the string from the beginning and end
367367
size_t keep_size = (width - placeholder_size) / 2; // Portion to keep from each side
368368
size_t keep_end = result.size() - keep_size;
369-
int line_size = 2 * keep_size + placeholder.size();
369+
int line_size = static_cast<int>(2 * keep_size + placeholder.size());
370370

371371
while (line_size < width) {
372372
if (keep_end > 0) {
@@ -391,9 +391,10 @@ namespace logit {
391391
if (left_align) {
392392
// Left alignment
393393
oss << std::left << std::setw(width) << result;
394-
} else if (center_align) {
394+
} else
395+
if (center_align) {
395396
// Center alignment
396-
const int padding = (width - result.size()) / 2;
397+
const int padding = static_cast<int>((width - result.size()) / 2);
397398
oss << std::string(padding, ' ') << result << std::string(width - padding - result.size(), ' ');
398399
} else {
399400
// Right alignment (default)

include/log-it/parts/LogMacros.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#pragma once
22
#ifndef _LOGIT_LOG_MACROS_HPP_INCLUDED
33
#define _LOGIT_LOG_MACROS_HPP_INCLUDED
4+
45
/// \file LogMacros.hpp
56
/// \brief Provides various logging macros for different log levels and options.
67

0 commit comments

Comments
 (0)