Skip to content

Add Saflok Emulation Support #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Add Saflok Emulation Support #461

wants to merge 6 commits into from

Conversation

aaronjamt
Copy link
Member

@aaronjamt aaronjamt commented Aug 28, 2025 •
edited
Loading

Superseded by #474

What's new

  • Adds the ability to create and emulate Saflok hotel keycards using Mifare Classic 1k

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@aaronjamt aaronjamt mentioned this pull request Aug 28, 2025
Open
@aaronjamt aaronjamt marked this pull request as draft September 4, 2025 22:41
@aaronjamt
Copy link
Member Author

Marking as draft, awaiting merge of Xero firmware updates.

@aaronjamt aaronjamt marked this pull request as ready for review September 6, 2025 05:42
aaronjamt
aaronjamt commented Sep 6, 2025
View reviewed changes
applications/main/nfc/helpers/saflok.c
Comment on lines +241 to +245
// This is the default log header for cards with no log data
// 00 00 00 00 00 00 00 00 00 00 00 C1 00 00 00 00
if(block == 4) {
mfc_data->block[block].data[11] = 0xC1;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on my MT lock, but I'd like more testing to verify it works on others as well.

aaronjamt and others added 3 commits September 6, 2025 06:24
@aaronjamt
Create Saflok API
3139bf1 
This prevents code reuse of the Saflok functions that are common across both the parser and generator.
@aaronjamt
Improve UI/UX
32ddce4 
Based on suggestions by @xtruan
@aaronjamt @xtruan
Add Saflok MFULC parser
f4433c9 
Written by @xtruan. Thanks for the contribution!

Co-authored-by: xtruan <xtruan@users.noreply.github.com>
@aaronjamt
Copy link
Member Author

aaronjamt commented Sep 10, 2025 •
edited
Loading

I should also note that this PR should be merged first: flipperdevices/flipperzero-firmware#4261
Edit to add: v1 of that PR was already merged, but there's a new commit from a couple days ago that adds another function to the API.
If you don't want to merge the extra commit yet, I can revert it and make a new PR later for it.

@aaronjamt
Copy link
Member Author

Superseded by #474

@aaronjamt aaronjamt closed this Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillyJL WillyJL Awaiting requested review from WillyJL WillyJL is a code owner

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

@956MB 956MB Awaiting requested review from 956MB 956MB is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronjamt @WillyJL