Skip to content

Commit 1a356bf

Browse files
committed
chore: update workflow and make controller method tryStartWorker private
1 parent a19ae79 commit 1a356bf

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

.github/workflows/release.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,8 @@ jobs:
1717

1818
- name: Semantic Release
1919
id: semantic
20-
uses: cycjimmy/semantic-release-action@v3.4.1
20+
uses: cycjimmy/semantic-release-action@v4
2121
with:
22-
semantic_version: 18
2322
extra_plugins: |
2423
@semantic-release/release-notes-generator@^10
2524
@semantic-release/github@^8
@@ -38,10 +37,8 @@ jobs:
3837
- id: meta
3938
uses: docker/metadata-action@v4
4039
with:
41-
images: |
42-
tensorfusion/tensor-fusion-operator
43-
tags: |
44-
type=semver,pattern={{needs.release.outputs.version}}
40+
images: tensorfusion/tensor-fusion-operator
41+
tags: type=semver,pattern=${{needs.release.outputs.version}}
4542
- name: Login to DockerHub
4643
uses: docker/login-action@v2
4744
with:
@@ -54,4 +51,5 @@ jobs:
5451
context: .
5552
push: true
5653
tags: ${{ steps.meta.outputs.tags }}
54+
labels: ${{ steps.meta.outputs.labels }}
5755
no-cache: true

internal/controller/tensorfusionconnection_controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ func (r *TensorFusionConnectionReconciler) Reconcile(ctx context.Context, req ct
116116
}
117117

118118
// Start worker job
119-
phase, err := r.TryStartWorker(ctx, connection, types.NamespacedName{Name: connection.Name, Namespace: connection.Namespace})
119+
phase, err := r.tryStartWorker(ctx, connection, types.NamespacedName{Name: connection.Name, Namespace: connection.Namespace})
120120
if err != nil {
121121
log.Error(err, "Failed to start worker pod")
122122
return ctrl.Result{}, err
@@ -140,7 +140,7 @@ func (r *TensorFusionConnectionReconciler) Reconcile(ctx context.Context, req ct
140140
return ctrl.Result{}, nil
141141
}
142142

143-
func (r *TensorFusionConnectionReconciler) TryStartWorker(ctx context.Context, connection *tfv1.TensorFusionConnection, namespacedName types.NamespacedName) (corev1.PodPhase, error) {
143+
func (r *TensorFusionConnectionReconciler) tryStartWorker(ctx context.Context, connection *tfv1.TensorFusionConnection, namespacedName types.NamespacedName) (corev1.PodPhase, error) {
144144
// Try to get the Pod
145145
pod := &corev1.Pod{}
146146
if err := r.Get(ctx, namespacedName, pod); err != nil {

0 commit comments

Comments
 (0)