diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 44d7181..f9c5fa9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -17,9 +17,8 @@ jobs: - name: Semantic Release id: semantic - uses: cycjimmy/semantic-release-action@v3.4.1 + uses: cycjimmy/semantic-release-action@v4 with: - semantic_version: 18 extra_plugins: | @semantic-release/release-notes-generator@^10 @semantic-release/github@^8 @@ -38,10 +37,8 @@ jobs: - id: meta uses: docker/metadata-action@v4 with: - images: | - tensorfusion/tensor-fusion-operator - tags: | - type=semver,pattern={{needs.release.outputs.version}} + images: tensorfusion/tensor-fusion-operator + tags: type=semver,pattern=${{needs.release.outputs.version}} - name: Login to DockerHub uses: docker/login-action@v2 with: @@ -54,4 +51,5 @@ jobs: context: . push: true tags: ${{ steps.meta.outputs.tags }} + labels: ${{ steps.meta.outputs.labels }} no-cache: true diff --git a/internal/controller/tensorfusionconnection_controller.go b/internal/controller/tensorfusionconnection_controller.go index 7d024a4..426fd62 100644 --- a/internal/controller/tensorfusionconnection_controller.go +++ b/internal/controller/tensorfusionconnection_controller.go @@ -116,7 +116,7 @@ func (r *TensorFusionConnectionReconciler) Reconcile(ctx context.Context, req ct } // Start worker job - phase, err := r.TryStartWorker(ctx, connection, types.NamespacedName{Name: connection.Name, Namespace: connection.Namespace}) + phase, err := r.tryStartWorker(ctx, connection, types.NamespacedName{Name: connection.Name, Namespace: connection.Namespace}) if err != nil { log.Error(err, "Failed to start worker pod") return ctrl.Result{}, err @@ -140,7 +140,7 @@ func (r *TensorFusionConnectionReconciler) Reconcile(ctx context.Context, req ct return ctrl.Result{}, nil } -func (r *TensorFusionConnectionReconciler) TryStartWorker(ctx context.Context, connection *tfv1.TensorFusionConnection, namespacedName types.NamespacedName) (corev1.PodPhase, error) { +func (r *TensorFusionConnectionReconciler) tryStartWorker(ctx context.Context, connection *tfv1.TensorFusionConnection, namespacedName types.NamespacedName) (corev1.PodPhase, error) { // Try to get the Pod pod := &corev1.Pod{} if err := r.Get(ctx, namespacedName, pod); err != nil {