feat(access-list): add optional note field to access list clients

backend/internal/access-list.js

@@ -54,6 +54,7 @@ const internalAccessList = {
 				accessListClientModel.query().insert({
 					access_list_id: row.id,
 					address: client.address,
+					note: client.note || null,
 					directive: client.directive,
 				}),
 			);
@@ -161,6 +162,7 @@ const internalAccessList = {
 						accessListClientModel.query().insert({
 							access_list_id: data.id,
 							address: client.address,
+							note: client.note || null,
 							directive: client.directive,
 						}),
 					);

backend/lib/utils.js

@@ -92,18 +92,26 @@ const getRenderEngine = () => {
 	});
 
 	/**
-	 * nginxAccessRule expects the object given to have 2 properties:
+	 * nginxAccessRule expects the object given to have 3 properties:
 	 *
 	 * directive  string
 	 * address    string
+	 * note		  string
 	 */
 	renderEngine.registerFilter("nginxAccessRule", (v) => {
-		if (typeof v.directive !== "undefined" && typeof v.address !== "undefined" && v.directive && v.address) {
-			return `${v.directive} ${v.address};`;
+	if (typeof v.directive !== "undefined" && typeof v.address !== "undefined" && v.directive && v.address) {
+		const note = typeof v.note === "string" ? v.note.trim() : "";
+		if (note) {
+		// prevent newline / comment-breaking characters
+		const safe = note.replace(/[\r\n#;]/g, " ").trim();
+		return `${v.directive} ${v.address}; # ${safe}`;
 		}
-		return "";
+		return `${v.directive} ${v.address};`;
+	}
+	return "";
 	});
 
+
 	return renderEngine;
 };
 

backend/migrations/20260220111310_access_list_client_note.js

@@ -0,0 +1,36 @@
+import { migrate as logger } from "../logger.js";
+
+const migrateName = "access_list_client_note";
+
+/**
+ * Migrate
+ *
+ * @see http://knexjs.org/#Schema
+ *
+ * @param   {Object}  knex
+ * @returns {Promise}
+ */
+const up = (knex) => {
+	logger.info(`[${migrateName}] Migrating Up...`);
+
+	return knex.schema
+		.table("access_list_client", (access_list) => {
+			access_list.string("note", 200).nullable()
+		})
+		.then(() => {
+			logger.info(`[${migrateName}] access_list_client Table altered`);
+		});
+};
+
+/**
+ * Undo Migrate
+ *
+ * @param   {Object}  knex
+ * @returns {Promise}
+ */
+const down = (_knex) => {
+	logger.warn(`[${migrateName}] You can't migrate down this one.`);
+	return Promise.resolve(true);
+};
+
+export { up, down };

backend/schema/common.json

@@ -156,6 +156,12 @@
 			],
 			"example": "192.168.0.11"
 		},
+		"note": {
+			"description": "Note",
+			"type": "string",
+			"example": "Home",
+			"maxLength": 200
+		},
 		"access_items": {
 			"type": "array",
 			"items": {
@@ -191,19 +197,24 @@
 					"address": {
 						"$ref": "#/properties/address"
 					},
+					"note": {
+						"$ref": "#/properties/note"
+					},
 					"directive": {
 						"$ref": "#/properties/directive"
 					}
 				},
 				"example": {
 					"directive": "allow",
-					"address": "192.168.0.0/24"
+					"address": "192.168.0.0/24",
+					"note": "Home"
 				}
 			},
 			"example": [
 				{
 					"directive": "allow",
-					"address": "192.168.0.0/24"
+					"address": "192.168.0.0/24",
+					"note": "Home"
 				}
 			]
 		},

backend/schema/paths/nginx/access-lists/listID/put.json

@@ -60,7 +60,8 @@
 					"clients": [
 						{
 							"directive": "allow",
-							"address": "192.168.0.0/24"
+							"address": "192.168.0.0/24",
+							"note": "note"
 						}
 					]
 				}

backend/schema/paths/nginx/access-lists/post.json

@@ -51,7 +51,8 @@
 					"clients": [
 						{
 							"directive": "allow",
-							"address": "192.168.0.0/24"
+							"address": "192.168.0.0/24",
+							"note": "note"
 						}
 					]
 				}
@@ -118,6 +119,7 @@
 										"modified_on": "2024-10-08T22:15:40.000Z",
 										"access_list_id": 1,
 										"address": "127.0.0.1",
+										"note": "note",
 										"directive": "allow",
 										"meta": {}
 									}

frontend/src/App.css

@@ -13,6 +13,10 @@
 	--tblr-backdrop-opacity: 0.8 !important;
 }
 
+.modal-dialog { 
+	max-width: 700px !important; 
+}
+
 [data-bs-theme="dark"] .modal-content {
 	--tblr-modal-box-shadow: 0 0.5rem 1rem rgba(0, 0, 0, 0.15) !important;
 }

frontend/src/api/backend/models.ts

@@ -77,6 +77,7 @@ export type AccessListClient = {
 	modifiedOn?: string;
 	accessListId?: number;
 	address: string;
+	note?: string;
 	directive: "allow" | "deny";
 	meta?: Record<string, any>;
 };

frontend/src/components/Form/AccessClientFields.tsx

@@ -78,6 +78,16 @@ export function AccessClientFields({ initialValues, name = "clients" }: Props) {
 								onChange={(e) => handleChange(idx, "address", e.target.value)}
 								placeholder={intl.formatMessage({ id: "access-list.rule-source.placeholder" })}
 							/>
+							<input
+								name={`clients[${idx}].note`}
+								type="text"
+								maxLength={200}
+								className="form-control"
+								autoComplete="off"
+								value={client.note ?? ""}
+								onChange={(e) => handleChange(idx, "note", e.target.value)}
+								placeholder={intl.formatMessage({ id: "access-list.rule-source.placeholder-note" })}
+							/>
 						</div>
 					</div>
 					<div className="col-1">

frontend/src/locale/src/bg.json

@@ -26,6 +26,9 @@
 	"access-list.rule-source.placeholder": {
 		"defaultMessage": "192.168.1.100 или 192.168.1.0/24 или 2001:0db8::/32"
 	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "Напр. „Дом“ или „Офис“"
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "Удовлетворяване на което и да е"
 	},
@@ -692,4 +695,4 @@
 	"users": {
 		"defaultMessage": "Потребители"
 	}
-}
+}

frontend/src/locale/src/cs.json

@@ -83,6 +83,9 @@
 	"access-list.rule-source.placeholder": {
 		"defaultMessage": "192.168.1.100 nebo 192.168.1.0/24 nebo 2001:0db8::/32"
 	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "Např. „Domov“ nebo „Kancelář“"
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "Splnit kterékoliv"
 	},
@@ -767,4 +770,4 @@
 	"users": {
 		"defaultMessage": "Uživatelé"
 	}
-}
+}

frontend/src/locale/src/de.json

@@ -23,6 +23,12 @@
 	"access-list.public.subtitle": {
 		"defaultMessage": "Keine Authentifizierung erforderlich"
 	},
+	"access-list.rule-source.placeholder": {
+		"defaultMessage": "192.168.1.100 oder 192.168.1.0/24 oder 2001:0db8::/32"
+	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "Z. B. „Zuhause“ oder „Büro“"
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "Satisfy Any"
 	},
@@ -653,4 +659,4 @@
 	"users": {
 		"defaultMessage": "Benutzer"
 	}
-}
+}

frontend/src/locale/src/en.json

@@ -83,6 +83,9 @@
 	"access-list.rule-source.placeholder": {
 		"defaultMessage": "192.168.1.100 or 192.168.1.0/24 or 2001:0db8::/32"
 	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "E.g. \"Home\" or \"Office\""
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "Satisfy Any"
 	},

frontend/src/locale/src/es.json

@@ -26,6 +26,9 @@
 	"access-list.rule-source.placeholder": {
 		"defaultMessage": "192.168.1.100 o 192.168.1.0/24 o 2001:0db8::/32"
 	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "P. ej., «Casa» u «Oficina»"
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "Satisfacer Cualquiera"
 	},
@@ -689,4 +692,4 @@
 	"users": {
 		"defaultMessage": "Usuarios"
 	}
-}
+}

frontend/src/locale/src/fr.json

@@ -23,6 +23,12 @@
 	"access-list.public.subtitle": {
 		"defaultMessage": "Aucune authentification de base requise"
 	},
+	"access-list.rule-source.placeholder": {
+		"defaultMessage": "192.168.1.100 ou 192.168.1.0/24 ou 2001:0db8::/32"
+	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "Par ex. « Domicile » ou « Bureau »"
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "Valide n'importe quelle règle"
 	},
@@ -644,4 +650,4 @@
 	"users": {
 		"defaultMessage": "Utilisateurs"
 	}
-}
+}

frontend/src/locale/src/ga.json

@@ -26,6 +26,9 @@
 	"access-list.rule-source.placeholder": {
 		"defaultMessage": "192.168.1.100 nó 192.168.1.0/24 nó 2001:0db8::/32"
 	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "M.sh. \"Baile\" nó \"Oifig\""
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "Sásaigh Aon"
 	},
@@ -680,4 +683,4 @@
 	"users": {
 		"defaultMessage": "Úsáideoirí"
 	}
-}
+}

frontend/src/locale/src/hu.json

@@ -83,6 +83,9 @@
 	"access-list.rule-source.placeholder": {
 		"defaultMessage": "192.168.1.100 vagy 192.168.1.0/24 vagy 2001:0db8::/32"
 	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "Pl. „Otthon” vagy „Iroda”"
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "Bármely teljesítése"
 	},
@@ -767,4 +770,4 @@
 	"users": {
 		"defaultMessage": "Felhasználók"
 	}
-}
+}

frontend/src/locale/src/id.json

@@ -26,6 +26,9 @@
 	"access-list.rule-source.placeholder": {
 		"defaultMessage": "192.168.1.100 atau 192.168.1.0/24 atau 2001:0db8::/32"
 	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "Mis. \"Rumah\" atau \"Kantor\""
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "Penuhi Salah Satu"
 	},
@@ -680,4 +683,4 @@
 	"users": {
 		"defaultMessage": "Pengguna"
 	}
-}
+}

frontend/src/locale/src/it.json

@@ -23,6 +23,12 @@
 	"access-list.public.subtitle": {
 		"defaultMessage": "Nessuna autenticazione base richiesta"
 	},
+	"access-list.rule-source.placeholder": {
+		"defaultMessage": "192.168.1.100 o 192.168.1.0/24 o 2001:0db8::/32"
+	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "Es. \"Casa\" o \"Ufficio\""
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "Soddisfa Qualsiasi"
 	},
@@ -656,4 +662,4 @@
 	"users": {
 		"defaultMessage": "Utenti"
 	}
-}
+}

frontend/src/locale/src/ja.json

@@ -23,6 +23,12 @@
 	"access-list.public.subtitle": {
 		"defaultMessage": "ベーシック認証を使用しません"
 	},
+	"access-list.rule-source.placeholder": {
+		"defaultMessage": "192.168.1.100 または 192.168.1.0/24 または 2001:0db8::/32"
+	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "例：「自宅」や「オフィス」"
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "いずれかを満たす"
 	},
@@ -650,4 +656,4 @@
 	"users": {
 		"defaultMessage": "ユーザー"
 	}
-}
+}

frontend/src/locale/src/ko.json

@@ -26,6 +26,9 @@
 	"access-list.rule-source.placeholder": {
 		"defaultMessage": "192.168.1.100 / 192.168.1.0/24 / IPv6"
 	},
+	"access-list.rule-source.placeholder-note": {
+		"defaultMessage": "예: \"집\" 또는 \"사무실\""
+	},
 	"access-list.satisfy-any": {
 		"defaultMessage": "조건 중 하나라도 충족"
 	},
@@ -692,4 +695,4 @@
 	"users": {
 		"defaultMessage": "사용자"
 	}
-}
+}