First class cross #13073
Open
First class cross #13073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
force-pushed
the
first-class-splicing
branch
from
d2c4405 to
281f6a8
Compare
roberth
added
the
build-problem
xokdvium
reviewed
Apr 25, 2025
flake.nix
Outdated
| ) (renameSplicesFrom "pkgs" pkgs); | ||
| nixDependenciesSplices = mapSplices ( | ||
| pkgs': (packageSetsFor (args // { pkgs = pkgs'; })).nixDependencies | ||
| ) (renameSplicesFrom "pkgs" pkgs); | ||
|
|
||
| # A new scope, so that we can use `callPackage` to inject our own interdependencies | ||
| # without "polluting" the top level "`pkgs`" attrset. | ||
| # This also has the benefit of providing us with a distinct set of packages | ||
| # we can iterate over. | ||
| # The `2` suffix is here because otherwise it interferes with `nixVersions.latest`, which is used in daemon compat tests. |
There was a problem hiding this comment.
This comment is now stale, right?
# The 2 suffix is here
There was a problem hiding this comment.
Yes, thanks. It's not in overlayFor, but here it is stale. The rest of the flake could perhaps move away from using overlayFor as a vehicle for storing its stuff, but that's somewhat of a large change for later.
This was carefully refactored by inlining some Nixpkgs definitions like `generateSplicesForMkScope`, so the memoization properties should remain the same.
Users can access these through the `lib.makeComponents` return value, so it's helpful to briefly explain some of them. This doesn't replace `meta.description`, but supplements it. (TODO: improve `meta.description`)
We should keep users' pkgs tidy.
roberth
force-pushed
the
first-class-splicing
branch
from
281f6a8 to
d2227af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cross packaging shouldn't depend on having and using overlay.
This PR makes it possible to cross-compile without using any overlays whatsoever.
The three helper functions could perhaps be moved to Nixpkgs lib. cc @Ericson2314
See also commit messages.
Context
The packaging problems in hydra and flake.lock: Update Nixpkgs #13010 motivated me to try improve this again.
This must have been my third attempt at this. I had previously got stuck on a Nixpkgs quirk; see comment at
fixup =.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.