Skip to content

docker: set default parameters values #13469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jul 13, 2025

Should fix #13443

Motivation

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@drupol drupol requested a review from edolstra as a code owner July 13, 2025 20:50
@edolstra
Copy link
Member

edolstra commented Jul 14, 2025

I'm not sure whether we should be exposing docker.nix at all, since AFAIK it's intended to be internal to our release process. And we definitely shouldn't document non-reproducible build instructions like

nix build --file docker.nix

(i.e. non-flake and depending on <nixpkgs>.)

@drupol
Copy link
Contributor Author

drupol commented Jul 14, 2025

Hello,

Let me know what I could do to improve the situation and I'll gladly do it.

IMO, I still believe that this is a good thing to expose the OCI container which is the official docker image pushed on hub.docker.com.

Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixing an existing problem. Removing this interface or removing from docs can be another PR if desired.

@github-project-automation github-project-automation bot moved this to Triage in Nix team Jul 16, 2025
@edolstra edolstra removed this from Nix team Jul 16, 2025
@edolstra edolstra merged commit 17c94ca into NixOS:master Jul 16, 2025
12 checks passed
@drupol drupol deleted the push-nnwkpwsowkqm branch July 16, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build image from docker.nix following documentation
3 participants