Revert "Add a crude tracing mechansim for the build results"#13853
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Aug 28, 2025
Merged
Revert "Add a crude tracing mechansim for the build results"#13853xokdvium merged 1 commit intoNixOS:masterfrom
xokdvium merged 1 commit intoNixOS:masterfrom
Conversation
The commit says it was added for CA testing --- manual I assume, since there is no use of this in the test suite. I don't think we need it any more, and I am not sure whether it was ever supposed to have made it to `master` either. This reverts commit 2eec2f7.
Member
|
BTW, this DetSys PR (partially upstreamed) adds proper tracing of build results using structured JSON log messages: DeterminateSystems#13. I can have a look at making an upstream PR for the JSON serialization. |
Member
Author
|
Yeah your PR is much more principled, that sounds like a good plan. I think it would be fine to merge this now, and when you upstream it, it can just add fresh |
xokdvium
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The commit says it was added for CA testing --- manual I assume, since there is no use of this in the test suite. I don't think we need it any more, and I am not sure whether it was ever supposed to have made it to
mastereither.This reverts commit 2eec2f7.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.