Skip to content

Conversation

GaetanLepage
Copy link
Contributor

Things done

Currently broken on master (no trivial fix).
Also, the last commit was made on 2021-02-25.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 16, 2025
@nix-owners nix-owners bot requested a review from natsukium February 16, 2025 22:28
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 16, 2025
@GaetanLepage GaetanLepage requested a review from NickCao February 16, 2025 22:35
@NickCao NickCao merged commit dfd1f46 into NixOS:master Feb 16, 2025
22 checks passed
@GaetanLepage GaetanLepage deleted the cufflinks branch February 16, 2025 23:07
@FliegendeWurst
Copy link
Member

For the record, I had found a proper fix here: https://github.com/NixOS/nixpkgs/pull/371377/files#diff-6e88c5509df5d01da995c02c74a9bb826a31b2d2ba4d1f107d3af1d8226ddfd0 / santosjorge/cufflinks#288

Though I have no objection to the removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants