Skip to content

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 29, 2025

Diff: GitGuardian/py-gitguardian@refs/tags/v1.20.0...refs/tags/v1.21.0

Changelog: https://github.com/GitGuardian/py-gitguardian/blob/v1.21.0/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 29, 2025
@sarahec
Copy link
Contributor

sarahec commented Apr 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402932


aarch64-darwin

❌ 2 packages failed to build:
  • ggshield
  • ggshield.dist
✅ 4 packages built:
  • python312Packages.pygitguardian
  • python312Packages.pygitguardian.dist
  • python313Packages.pygitguardian
  • python313Packages.pygitguardian.dist

@sarahec
Copy link
Contributor

sarahec commented Apr 30, 2025

UPDATE: It appears to be unrelated to your change, but to ggshield depending on old packages. GitGuardian/ggshield#1091

The ggshield breakage:

error: builder for '/nix/store/i8aapckiic2r77xh06s4mhii0jciaf4v-ggshield-1.38.1.drv' failed with exit code 2;
       last 25 log lines:
       > <frozen importlib._bootstrap>:690: in _load_unlocked
       >     ???
       > /nix/store/h3piq8dh96lwvvawabf90frdwl6yabhn-python3.11-pytest-8.3.5/lib/python3.11/site-packages/_pytest/assertion/rewrite.py:185: in exec_module
       >     exec(co, module.__dict__)
       > tests/unit/conftest.py:60: in <module>
       >     _MULTIPLE_SECRETS_SCAN_RESULT = ScanResult.SCHEMA.load(
       > /nix/store/m4gnirj4cwf5xsiswia9aic1zgp4biiz-python3.11-marshmallow-3.26.1/lib/python3.11/site-packages/marshmallow/schema.py:792: in load
       >     return self._do_load(
       > /nix/store/m4gnirj4cwf5xsiswia9aic1zgp4biiz-python3.11-marshmallow-3.26.1/lib/python3.11/site-packages/marshmallow/schema.py:999: in _do_load
       >     raise exc
       > E   marshmallow.exceptions.ValidationError: {'policy_breaks': {0: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}}}
       > =============================== warnings summary ===============================
       > ../../../../nix/store/m4gnirj4cwf5xsiswia9aic1zgp4biiz-python3.11-marshmallow-3.26.1/lib/python3.11/site-packages/marshmallow/schema.py:129: 76 warnings
       >   /nix/store/m4gnirj4cwf5xsiswia9aic1zgp4biiz-python3.11-marshmallow-3.26.1/lib/python3.11/site-packages/marshmallow/schema.py:129: RemovedInMarshmallow4Warning: The `ordered` `class Meta` option is deprecated. Field order is already preserved by default. Set `Schema.dict_class` to OrderedDict to maintain the previous behavior.
       >     klass.opts = klass.OPTIONS_CLASS(meta, ordered=ordered)
       >
       > ../../../../nix/store/v6kn4kfz1p79ap5c9yd1iry4znd5hbds-python3.11-pygitguardian-1.21.0/lib/python3.11/site-packages/pygitguardian/models.py:543
       >   /nix/store/v6kn4kfz1p79ap5c9yd1iry4znd5hbds-python3.11-pygitguardian-1.21.0/lib/python3.11/site-packages/pygitguardian/models.py:543: ChangedInMarshmallow4Warning: `Mapping` field should not be instantiated. Use `Dict` instead.
       >     token = fields.Mapping(fields.String(), fields.String())
       >
       > -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
       > =========================== short test summary info ============================
       > ERROR tests/unit - marshmallow.exceptions.ValidationError: {'policy_breaks': {0: {'detector_na...
       > !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
       > ======================== 77 warnings, 1 error in 1.74s =========================

Copy link
Contributor

@sarahec sarahec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the ggshield breakage seems unrelated

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 30, 2025
@fabaff
Copy link
Member Author

fabaff commented Apr 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402932


x86_64-linux

✅ 6 packages built:
  • ggshield
  • ggshield.dist
  • python312Packages.pygitguardian
  • python312Packages.pygitguardian.dist
  • python313Packages.pygitguardian
  • python313Packages.pygitguardian.dist

@sarahec sarahec self-requested a review April 30, 2025 23:32

This comment was marked as outdated.

@sarahec
Copy link
Contributor

sarahec commented Apr 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402932


aarch64-darwin

✅ 6 packages built:
  • ggshield
  • ggshield.dist
  • python312Packages.pygitguardian
  • python312Packages.pygitguardian.dist
  • python313Packages.pygitguardian
  • python313Packages.pygitguardian.dist

@fabaff
Copy link
Member Author

fabaff commented May 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402932


x86_64-linux

✅ 6 packages built:
  • ggshield
  • ggshield.dist
  • python312Packages.pygitguardian
  • python312Packages.pygitguardian.dist
  • python313Packages.pygitguardian
  • python313Packages.pygitguardian.dist

@fabaff fabaff merged commit e9b57df into NixOS:master May 1, 2025
27 of 29 checks passed
@fabaff fabaff deleted the pygitguardian-bump branch May 1, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants