chore: Remove unused old properties

Author: Aeltumn

interfaces/src/main/kotlin/com/noxcrew/interfaces/view/AbstractInterfaceView.kt

@@ -154,10 +154,6 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
     override val isTreeOpened: Boolean
         get() = shouldStillBeOpened || children.keys.any { it.isTreeOpened }
 
-    /** Whether this menu type overlaps the player inventory. */
-    public open val overlapsPlayerInventory: Boolean
-        get() = false
-
     /** The pane of this view. */
     public val completedPane: CompletedPane?
         get() = if (::pane.isInitialized) pane else null
@@ -479,12 +475,7 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
                     pane = panes.collapse(backing.mapper, builder.allowClickingEmptySlots)
 
                     // Render the completed panes
-                    renderToInventory { createdNewInventory ->
-                        // send an update packet if necessary
-                        if (!createdNewInventory && requiresPlayerUpdate()) {
-                            player.updateInventory()
-                        }
-                    }
+                    renderToInventory()
                 }
             }
         } finally {
@@ -813,9 +804,7 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
 
     protected open fun requiresNewInventory(): Boolean = firstPaint
 
-    protected open fun requiresPlayerUpdate(): Boolean = false
-
-    protected open suspend fun renderToInventory(callback: (Boolean) -> Unit) {
+    protected open suspend fun renderToInventory() {
         // If the menu has since been requested to close we ignore all this
         if (!shouldBeOpened.get()) return
 
@@ -866,7 +855,6 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
                 // ended up being opened.
                 val isOpen = isOpen()
                 drawPaneToInventory(drawNormalInventory = true, drawPlayerInventory = isOpen)
-                callback(createdInventory)
                 InterfacesProfiler.log(this, "finished rendering to inventory")
 
                 if (this is PlayerInterfaceView) {

interfaces/src/main/kotlin/com/noxcrew/interfaces/view/ChestInterfaceView.kt

@@ -44,8 +44,6 @@ public class ChestInterfaceView internal constructor(
         titleState.current = backing.titleSupplier?.invoke(player)
     }
 
-    override fun requiresPlayerUpdate(): Boolean = false
-
     override fun requiresNewInventory(): Boolean = super.requiresNewInventory() || titleState.hasChanged
 
     override fun getInventory(): Inventory = currentInventory.chestInventory

interfaces/src/main/kotlin/com/noxcrew/interfaces/view/CombinedInterfaceView.kt

@@ -24,8 +24,6 @@ public class CombinedInterfaceView internal constructor(
 
     private val titleState = TitleState()
 
-    override val overlapsPlayerInventory: Boolean = true
-
     override fun title(value: Component) {
         titleState.current = value
     }
@@ -47,8 +45,6 @@ public class CombinedInterfaceView internal constructor(
         titleState.current = backing.titleSupplier?.invoke(player)
     }
 
-    override fun requiresPlayerUpdate(): Boolean = false
-
     override fun requiresNewInventory(): Boolean = super.requiresNewInventory() || titleState.hasChanged
 
     override fun getInventory(): Inventory = currentInventory.chestInventory

interfaces/src/main/kotlin/com/noxcrew/interfaces/view/PlayerInterfaceView.kt

@@ -21,8 +21,6 @@ public class PlayerInterfaceView internal constructor(
     null
 ) {
 
-    override val overlapsPlayerInventory: Boolean = true
-
     override fun title(value: Component) {
         error("PlayerInventoryView's cannot have a title")
     }