fix(discovery): test if file contains test #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I just saw that #37 also adresses this. In my test it did not slow down my test discovery significantly for a project with over 700 tests. That project used the mtp client, so I guess the vstest client may be slower. I'll check if the file is updated to become a test file later if it starts to contain tests. |
|
Neotest does indeed rescan the file and adds it to the list. It is not immediate, I assumes theres some sort of worker periodically checking the files. |
Dynge
force-pushed
the
mdl/push-pzyrmtktnkmp
branch
2 times, most recently
from
b337517 to
d73a9f3
Compare
The method to determine if the file is a test file did not take into account that it actually had tests for the file. It just checked that the file is from a project with a client. There may be files that are not test files within the project.
Dynge
force-pushed
the
mdl/push-pzyrmtktnkmp
branch
from
d73a9f3 to
828b9fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method to determine if the file is a test file did not take into account that it actually had tests for the file. It just checked that the file is from a project with a client.
There may be files that are not test files within the project.