nextcloud: drop configureRecognize in favor of upstream package (#224)

Author: SuperSandro2000

modules/nextcloud.nix

@@ -28,17 +28,19 @@ in
           By default this is enabled, when Imaginary is configured.
         '';
       };
-
-      configureRecognize = lib.mkEnableOption "" // { description = ''
-        Whether to configure dependencies for Recognize App.
-
-        ::: {.note}
-        This currently does not work with declerataive installed apps.
-        :::
-      ''; };
     };
   };
 
+  imports = [
+    (lib.mkRemovedOptionModule ["services" "nextcloud" "configureRecognize"] ''
+      configureRecognize has been removed in favor of using the recognize packages from NixOS like:
+
+      services.nextcloud.extraApps = {
+        inherit (pkgs."nextcloud${lib.versions.major config.services.nextcloud.package.version}Packages".apps) recognize;
+      };
+    '')
+  ];
+
   config = lib.mkIf cfg.enable {
     services = {
       imaginary = lib.mkIf cfg.configureImaginary {
@@ -185,19 +187,6 @@ in
           };
         };
 
-        nextcloud-setup = lib.mkIf cfg.configureRecognize {
-          script = /* bash */ ''
-            export PATH=$PATH:/etc/profiles/per-user/nextcloud/bin:/run/current-system/sw/bin
-
-            if [[ ! -e ${cfg.home}/store-apps/recognize/node_modules/@tensorflow/tfjs-node/lib/napi-v8/tfjs_binding.node ]]; then
-              if [[ -d ${cfg.home}/store-apps/recognize/node_modules/ ]]; then
-                cd ${cfg.home}/store-apps/recognize/node_modules/
-                npm rebuild @tensorflow/tfjs-node --build-addon-from-source
-              fi
-            fi
-          '';
-        };
-
         phpfpm-nextcloud.serviceConfig = lib.mkIf (cfg.configureMemories && cfg.configureMemoriesVaapi) {
           DeviceAllow = [ "/dev/dri/renderD128 rwm" ];
           PrivateDevices = lib.mkForce false;
@@ -225,16 +214,7 @@ in
         # generate video thumbnails with preview generator
         lib.optional cfg.configurePreviewSettings ffmpeg-headless
         # required for memories, duplicated with nextcloud-cron to better debug
-        ++ lib.optional cfg.configureMemories perl
-        # required for recognize app
-        ++ lib.optionals cfg.configureRecognize [
-          gnumake # installation requirement
-          nodejs_20 # runtime and installation requirement
-          # TODO: drop with 23.11
-          (pkgs.node-pre-gyp or nodejs_20.pkgs.node-pre-gyp) # installation requirement
-          python3 # requirement for node-pre-gyp otherwise fails with exit code 236
-          util-linux # runtime requirement for taskset
-        ];
+        ++ lib.optional cfg.configureMemories perl;
     };
   };
 }