[FIX] account_statement_import_online_paypal: Fix error importing Pay…#858
[FIX] account_statement_import_online_paypal: Fix error importing Pay…#858sefirosweb wants to merge 2 commits into
Conversation
…Pal transactions with null fee_amount (OCA#857) This commit solves issue OCA#857 (OCA#857), which caused an error when importing PayPal transactions with a null fee_amount. Additionally, it fixes the way raw_data is stored in the database to ensure it can be correctly retrieved and processed later. Co-authored-by: Sefirosweb
|
Hi @alexey-pelykh, |
|
This PR removes the function The only remaining reference to this method is in a very specific unit test, In other words: the failure does not come from a regression, but from a test I am opening this PR so the maintainers can review whether this test still has Please confirm whether the test should be kept, adapted, or removed given the best, |
alexey-pelykh
left a comment
There was a problem hiding this comment.
Good refactoring — consolidating the date parsing into _paypal_get_transaction_date and dropping _paypal_preparse_transaction makes the flow cleaner. One thing to note: raw_data changes from a dict to json.dumps(transaction) (string), which is a behavior change for anything reading raw_data downstream. Tests are currently failing — once CI is green this will be easier to evaluate fully.
[FIX] account_statement_import_online_paypal: Fix error importing PayPal transactions with null fee_amount (#857)
This commit solves issue #857 (#857), which caused an error when importing PayPal transactions with a null fee_amount.
Additionally, it fixes the way raw_data is stored in the database to ensure it can be correctly retrieved and processed later.