[FIX] account_statement_import_sheet_file: support for reading XLSX files in addition to XLS and CSV formats#876
Draft
[FIX] account_statement_import_sheet_file: support for reading XLSX files in addition to XLS and CSV formats#876
Conversation
Contributor
|
Hi @alexey-pelykh, |
rov-adhoc
force-pushed
the
18.0-h-103320-rov
branch
from
0cd5163 to
fb709ce
Compare
Contributor
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for tackling XLSX support with openpyxl. One thought -- there's also #873 which takes a cleaner approach by fully replacing xlrd with openpyxl rather than maintaining a dual-path with hasattr() checks throughout. The dual approach adds maintenance burden since every future change to sheet parsing needs both xlrd and openpyxl code paths. Might be worth coordinating with #873 on the direction.
…iles in addition to XLS and CSV formats
rov-adhoc
force-pushed
the
18.0-h-103320-rov
branch
from
fb709ce to
889a708
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.