[IMP] l10n_it_fatturapa_in: intermediary contact creation depending by vat

Author: Chionne27

l10n_it_fatturapa_in/__manifest__.py

@@ -25,6 +25,7 @@
         "views/partner_view.xml",
         "wizard/wizard_import_fatturapa_view.xml",
         "wizard/link_to_existing_invoice.xml",
+        "wizard/wizard_check_intermediary_vat.xml",
         "views/company_view.xml",
         "security/ir.model.access.csv",
         "security/rules.xml",

l10n_it_fatturapa_in/security/ir.model.access.csv

@@ -6,6 +6,8 @@ access_einvoice_line_other_data,access_einvoice_line_other_data,model_einvoice_l
 access_wizard_import_fatturapa,access_wizard_import_fatturapa,model_wizard_import_fatturapa,account.group_account_invoice,1,1,1,1
 access_wizard_link_to_invoice,access_wizard_link_to_invoice,model_wizard_link_to_invoice,account.group_account_invoice,1,1,1,1
 access_wizard_link_to_invoice_line,access_wizard_link_to_invoice_line,model_wizard_link_to_invoice_line,account.group_account_invoice,1,1,1,1
+access_wizard_check_intermediary_all,access_wizard_check_intermediary_all,model_wizard_check_intermediary,account.group_account_invoice,1,1,1,1
+access_wizard_check_intermediary_all_line,access_wizard_check_intermediary_all_line,model_wizard_check_intermediary_line,account.group_account_invoice,1,1,1,1
 fatturapa_in_decimal_precision_access_manager,fatturapa_in_decimal_precision_access_manager,base.model_decimal_precision,account.group_account_manager,1,1,0,0
 fatturapa_in_decimal_precision_access_billing,fatturapa_in_decimal_precision_access_billing,base.model_decimal_precision,account.group_account_invoice,1,1,0,0
 fatturapa_in_mail_followers_access_manager,fatturapa_in_mail_followers_access_manager,mail.model_mail_followers,account.group_account_manager,1,1,0,0

l10n_it_fatturapa_in/tests/fatturapa_common.py

@@ -286,7 +286,51 @@ def run_wizard(
                 )
             )
             wizard = wizard_form.save()
-            return wizard.importFatturaPA()
+            res = wizard.importFatturaPA()
+
+            # NEW WIZARD INTERMEDIARY CREATION BASED ON VAT CHECK
+            # Case where the confirmation wizard is shown
+            if res.get("res_model") == "wizard.check.intermediary":
+
+                # fatturaPA can contain multiple invoices (intermediaries) with the same header
+                # In this case, we only handle a single line.
+                line = (
+                    self.env["wizard.check.intermediary"].browse(res["res_id"]).line_ids
+                )
+
+                invoice_id = line.invoice_id
+                name = line.name
+                vat = line.vat
+                wizard_id = line.wizard_id
+
+                # Check that the wizard was opened with the correct values
+                self.assertTrue(invoice_id, "invoice_id not present in context")
+
+                # Simulate the wizard behaviour
+                wizard = self.env["wizard.check.intermediary"].create(
+                    {
+                        "line_ids": [
+                            (
+                                0,
+                                0,
+                                {
+                                    "invoice_id": invoice_id.id,
+                                    "name": name,
+                                    "vat": vat,
+                                    "wizard_id": wizard_id,
+                                },
+                            )
+                        ],
+                        "invoice_ids": [(6, 0, [invoice_id.id])],
+                    }
+                )
+
+                res = wizard.action_confirm()
+                return res
+
+            else:
+                return res
+
         if mode == "link":
             wizard_form = Form(
                 self.wizard_link_model.with_context(

l10n_it_fatturapa_in/tests/test_import_fatturapa_xml.py

@@ -154,6 +154,7 @@ def test_04_xml_import(self):
         invoice.ref = invoice.payment_reference = "14041"
 
     def test_05_xml_import(self):
+        # res = self.run_wizard("test5", "IT05979361218_003.xml")
         res = self.run_wizard("test5", "IT05979361218_003.xml")
         invoice_id = res.get("domain")[0][2][0]
         invoice = self.invoice_model.browse(invoice_id)
@@ -327,6 +328,7 @@ def test_12_xml_import(self):
         res = self.run_wizard("test12", "IT05979361218_008.xml")
         invoice_id = res.get("domain")[0][2][0]
         invoice = self.invoice_model.browse(invoice_id)
+        # Final assertions regardless of the path
         self.assertEqual(invoice.payment_reference, "FT/2015/0012")
         self.assertEqual(invoice.sender, "TZ")
         self.assertEqual(invoice.intermediary.name, "MARIO ROSSI")

l10n_it_fatturapa_in/wizard/__init__.py

@@ -1,2 +1,3 @@
 from . import wizard_import_fatturapa
+from . import wizard_check_intermediary_vat
 from . import link_to_existing_invoice

l10n_it_fatturapa_in/wizard/wizard_check_intermediary_vat.py

@@ -0,0 +1,51 @@
+from odoo import fields, models
+
+
+class WizardCheckIntermediaryVat(models.TransientModel):
+    _name = "wizard.check.intermediary"
+    _description = "Intermediary VAT Check"
+
+    line_ids = fields.One2many(
+        comodel_name="wizard.check.intermediary.line", inverse_name="wizard_id"
+    )
+    invoice_ids = fields.Many2many(comodel_name="account.move")
+
+    def action_confirm(self):
+        for line in self.line_ids:
+            partner = self.env["res.partner"].create(
+                {
+                    "name": line.name,
+                    "vat": line.vat,
+                }
+            )
+
+            line.invoice_id.write({"intermediary": partner.id})
+
+        return {
+            "view_type": "form",
+            "name": "Electronic Bills",
+            "view_mode": "tree,form",
+            "res_model": "account.move",
+            "type": "ir.actions.act_window",
+            "domain": [("id", "in", self.invoice_ids.ids)],
+        }
+
+    def action_cancel(self):
+        return {
+            "view_type": "form",
+            "name": "Electronic Bills",
+            "view_mode": "tree,form",
+            "res_model": "account.move",
+            "type": "ir.actions.act_window",
+            "domain": [("id", "in", self.invoice_ids.ids)],
+        }
+
+
+class WizardCheckIntermediaryVatLine(models.TransientModel):
+    _name = "wizard.check.intermediary.line"
+    _description = "Intermediary VAT Check Line"
+
+    invoice_id = fields.Many2one("account.move", string="Invoice", readonly=True)
+    name = fields.Char()
+    vat = fields.Char()
+    wizard_id = fields.Many2one("wizard.check.intermediary")

l10n_it_fatturapa_in/wizard/wizard_check_intermediary_vat.xml

@@ -0,0 +1,40 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <record id="view_check_intermediary_vat" model="ir.ui.view">
+        <field name="name">check.intermediary.vat.form</field>
+        <field name="model">wizard.check.intermediary</field>
+        <field name="arch" type="xml">
+            <form string="Verify Intermediary">
+                <sheet>
+                    <group>
+                        <group>
+                            <p
+                            >These intermediaries do not exist on the system. Do you want to create them?</p>
+                        </group>
+                        <field name="line_ids" nolabel="1">
+                            <tree create="0">
+                                <field name="name" />
+                                <field name="vat" />
+                                <field name="invoice_id" />
+                            </tree>
+                        </field>
+                    </group>
+                    <footer>
+                        <button
+                            string="Confirm"
+                            type="object"
+                            name="action_confirm"
+                            class="btn-primary"
+                        />
+                        <button
+                            string="No"
+                            type="object"
+                            name="action_cancel"
+                            class="btn-secondary"
+                        />
+                    </footer>
+                </sheet>
+            </form>
+        </field>
+    </record>
+</odoo>

l10n_it_fatturapa_in/wizard/wizard_import_fatturapa.py

@@ -1850,7 +1850,7 @@ def _get_invoice_partner_id(self, fatt):
         partner_id = self.getCedPrest(cedentePrestatore)
         return partner_id
 
-    def importFatturaPA(self):
+    def importFatturaPA(self):  # noqa: C901
         self.ensure_one()
 
         (
@@ -1873,6 +1873,7 @@ def importFatturaPA(self):
 
         new_invoices = []
         # convert to dict in order to be able to modify context
+        new_intermediary_data = []
         fatturapa_attachments = self._get_selected_records()
         self.env.context = dict(self.env.context)
         for fatturapa_attachment in fatturapa_attachments:
@@ -1924,8 +1925,55 @@ def importFatturaPA(self):
                     )
                     invoice.write({"tax_representative_id": tax_partner_id})
                 if Intermediary:
-                    Intermediary_id = self.getPartnerBase(Intermediary.DatiAnagrafici)
-                    invoice.write({"intermediary": Intermediary_id})
+                    vat = False
+                    name = False
+                    if Intermediary.DatiAnagrafici.Anagrafica.Denominazione:
+                        name = Intermediary.DatiAnagrafici.Anagrafica.Denominazione
+                    else:
+                        nome = Intermediary.DatiAnagrafici.Anagrafica.Nome or ""
+                        cognome = Intermediary.DatiAnagrafici.Anagrafica.Cognome or ""
+                        name = f"{nome} {cognome}".strip()
+
+                    if Intermediary.DatiAnagrafici.IdFiscaleIVA:
+                        id_paese = (
+                            Intermediary.DatiAnagrafici.IdFiscaleIVA.IdPaese.upper()
+                        )
+                        id_codice = re.sub(
+                            r"\W+",
+                            "",
+                            Intermediary.DatiAnagrafici.IdFiscaleIVA.IdCodice,
+                        ).upper()
+                        # Format Italian VAT ID to always have 11 char
+                        # to avoid validation error when creating the given partner
+                        if id_paese == "IT" and not id_codice.startswith("IT"):
+                            vat = "IT{}".format(id_codice.rjust(11, "0")[:11])
+                        # XXX maybe San Marino needs special formatting too?
+                        else:
+                            vat = id_codice
+
+                        vat_check = self.env["res.partner"].search(
+                            [("vat", "=", vat), ("name", "=", name)]
+                        )
+
+                        if vat_check:
+                            invoice.write({"intermediary": vat_check.id})
+                        else:
+                            new_intermediary_data.append(
+                                {
+                                    "name": name,
+                                    "vat": vat,
+                                    "invoice_id": invoice.id,
+                                }
+                            )
+                    else:
+                        new_intermediary_data.append(
+                            {
+                                "name": name,
+                                "vat": vat,
+                                "invoice_id": invoice.id,
+                            }
+                        )
+
                 new_invoices.append(invoice.id)
                 self.check_invoice_amount(invoice, fattura)
 
@@ -1949,6 +1997,34 @@ def importFatturaPA(self):
                 discount_precision, original_discount_precision
             )
 
+        if new_intermediary_data:
+            res = self.env["wizard.check.intermediary"].create(
+                {
+                    "line_ids": [
+                        (
+                            0,
+                            0,
+                            {
+                                "name": new_data["name"],
+                                "vat": new_data["vat"],
+                                "invoice_id": new_data["invoice_id"],
+                            },
+                        )
+                        for new_data in new_intermediary_data
+                    ],
+                    "invoice_ids": [(6, 0, new_invoices)],
+                }
+            )
+
+            return {
+                "type": "ir.actions.act_window",
+                "name": "Confirm action",
+                "res_model": "wizard.check.intermediary",
+                "res_id": res.id,
+                "view_mode": "form",
+                "target": "new",
+            }
+
         return {
             "view_type": "form",
             "name": "Electronic Bills",