[IMP] l10n_it_fatturapa_in: Create intermediary contact by VAT

Chionne27 · Chionne27 · commit aa8db5335590 · 2025-08-18T14:02:03.000+02:00
This commit contains refactorings and module improvements to include intermediary search depending by vat
in e-invoice

[IMP] l10n_it_fatturapa_in: better partner search

[IMP] l10n_it_fatturapa_in: commercial partner search improvement
diff --git a/l10n_it_fatturapa_in/README.rst b/l10n_it_fatturapa_in/README.rst
@@ -1,7 +1,3 @@
-.. image:: https://odoo-community.org/readme-banner-image
-   :target: https://odoo-community.org/get-involved?utm_source=readme
-   :alt: Odoo Community Association
-
 =====================================
 ITA - Fattura elettronica - Ricezione
 =====================================
@@ -17,7 +13,7 @@ ITA - Fattura elettronica - Ricezione
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
     :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github
diff --git a/l10n_it_fatturapa_in/__manifest__.py b/l10n_it_fatturapa_in/__manifest__.py
@@ -25,6 +25,7 @@
         "views/partner_view.xml",
         "wizard/wizard_import_fatturapa_view.xml",
         "wizard/link_to_existing_invoice.xml",
+        "wizard/wizard_check_intermediary_vat.xml",
         "views/company_view.xml",
         "security/ir.model.access.csv",
         "security/rules.xml",
diff --git a/l10n_it_fatturapa_in/security/ir.model.access.csv b/l10n_it_fatturapa_in/security/ir.model.access.csv
@@ -6,6 +6,8 @@ access_einvoice_line_other_data,access_einvoice_line_other_data,model_einvoice_l
 access_wizard_import_fatturapa,access_wizard_import_fatturapa,model_wizard_import_fatturapa,account.group_account_invoice,1,1,1,1
 access_wizard_link_to_invoice,access_wizard_link_to_invoice,model_wizard_link_to_invoice,account.group_account_invoice,1,1,1,1
 access_wizard_link_to_invoice_line,access_wizard_link_to_invoice_line,model_wizard_link_to_invoice_line,account.group_account_invoice,1,1,1,1
+access_wizard_check_intermediary_all,access_wizard_check_intermediary_all,model_wizard_check_intermediary,account.group_account_invoice,1,1,1,1
+access_wizard_check_intermediary_all_line,access_wizard_check_intermediary_all_line,model_wizard_check_intermediary_line,account.group_account_invoice,1,1,1,1
 fatturapa_in_decimal_precision_access_manager,fatturapa_in_decimal_precision_access_manager,base.model_decimal_precision,account.group_account_manager,1,1,0,0
 fatturapa_in_decimal_precision_access_billing,fatturapa_in_decimal_precision_access_billing,base.model_decimal_precision,account.group_account_invoice,1,1,0,0
 fatturapa_in_mail_followers_access_manager,fatturapa_in_mail_followers_access_manager,mail.model_mail_followers,account.group_account_manager,1,1,0,0
diff --git a/l10n_it_fatturapa_in/static/description/index.html b/l10n_it_fatturapa_in/static/description/index.html
@@ -3,7 +3,7 @@
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>README.rst</title>
+<title>ITA - Fattura elettronica - Ricezione</title>
 <style type="text/css">
 
 /*
@@ -360,21 +360,16 @@
 </style>
 </head>
 <body>
-<div class="document">
+<div class="document" id="ita-fattura-elettronica-ricezione">
+<h1 class="title">ITA - Fattura elettronica - Ricezione</h1>
 
-
-<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
-<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
-</a>
-<div class="section" id="ita-fattura-elettronica-ricezione">
-<h1>ITA - Fattura elettronica - Ricezione</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:7c451f2c248991f81d741164a1b8f6f04f708e655f32ae61d9e148284381aed0
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-italy/tree/14.0/l10n_it_fatturapa_in"><img alt="OCA/l10n-italy" src="https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fatturapa_in"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-italy&amp;target_branch=14.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-italy/tree/14.0/l10n_it_fatturapa_in"><img alt="OCA/l10n-italy" src="https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fatturapa_in"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-italy&amp;target_branch=14.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p><strong>Italiano</strong></p>
 <p>Questo modulo consente di importare i file XML della fattura elettronica versione 1.2</p>
 <p><a class="reference external" href="http://www.fatturapa.gov.it/export/fatturazione/it/normativa/f-2.htm">http://www.fatturapa.gov.it/export/fatturazione/it/normativa/f-2.htm</a></p>
@@ -402,7 +397,7 @@ <h1>ITA - Fattura elettronica - Ricezione</h1>
 </ul>
 </div>
 <div class="section" id="installation">
-<h2><a class="toc-backref" href="#toc-entry-1">Installation</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-1">Installation</a></h1>
 <p><strong>Italiano</strong></p>
 <p>Questo modulo richiede asn1crypto</p>
 <p><a class="reference external" href="https://github.com/wbond/asn1crypto">https://github.com/wbond/asn1crypto</a></p>
@@ -411,7 +406,7 @@ <h2><a class="toc-backref" href="#toc-entry-1">Installation</a></h2>
 <p><a class="reference external" href="https://github.com/wbond/asn1crypto">https://github.com/wbond/asn1crypto</a></p>
 </div>
 <div class="section" id="configuration">
-<h2><a class="toc-backref" href="#toc-entry-2">Configuration</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-2">Configuration</a></h1>
 <p><strong>Italiano</strong></p>
 <p>Consultare anche il file README del modulo l10n_it_fatturapa.</p>
 <p>Per ciascun fornitore è possibile impostare il “Livello dettaglio e-fatture”:</p>
@@ -440,7 +435,7 @@ <h2><a class="toc-backref" href="#toc-entry-2">Configuration</a></h2>
 <p>If supplier specifies a known code in XML, the system will use it to retrieve the correct product to be used in bill line, setting the related tax and account.</p>
 </div>
 <div class="section" id="usage">
-<h2><a class="toc-backref" href="#toc-entry-3">Usage</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-3">Usage</a></h1>
 <p><strong>Italiano</strong></p>
 <blockquote>
 <ul class="simple">
@@ -463,7 +458,7 @@ <h2><a class="toc-backref" href="#toc-entry-3">Usage</a></h2>
 <p>In the incoming electronic bill files list you will see, by default, files to be registered. These are files not yet linked to one or more bills.</p>
 </div>
 <div class="section" id="known-issues-roadmap">
-<h2><a class="toc-backref" href="#toc-entry-4">Known issues / Roadmap</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-4">Known issues / Roadmap</a></h1>
 <p>Il modulo contiene un cambiamento alla firma di un metodo in <tt class="docutils literal">models/account.py</tt>
 il quale cambia da</p>
 <p><tt class="docutils literal">compute_xml_amount_untaxed(self, DatiRiepilogo)</tt></p>
@@ -479,24 +474,24 @@ <h2><a class="toc-backref" href="#toc-entry-4">Known issues / Roadmap</a></h2>
 dovranno adeguare la chiamata al metodo stesso preoccupandosi di utilizzare come primo parametro l’oggetto <tt class="docutils literal">FatturaElettronicaBody</tt>.</p>
 </div>
 <div class="section" id="bug-tracker">
-<h2><a class="toc-backref" href="#toc-entry-5">Bug Tracker</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-5">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/l10n-italy/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
 <a class="reference external" href="https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_fatturapa_in%0Aversion:%2014.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h2><a class="toc-backref" href="#toc-entry-6">Credits</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-6">Credits</a></h1>
 <div class="section" id="authors">
-<h3><a class="toc-backref" href="#toc-entry-7">Authors</a></h3>
+<h2><a class="toc-backref" href="#toc-entry-7">Authors</a></h2>
 <ul class="simple">
 <li>Agile Business Group</li>
 <li>Innoviu</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h3><a class="toc-backref" href="#toc-entry-8">Contributors</a></h3>
+<h2><a class="toc-backref" href="#toc-entry-8">Contributors</a></h2>
 <ul class="simple">
 <li>Lorenzo Battistini &lt;<a class="reference external" href="mailto:lorenzo.battistini&#64;agilebg.com">lorenzo.battistini&#64;agilebg.com</a>&gt;</li>
 <li>Roberto Onnis</li>
@@ -513,7 +508,7 @@ <h3><a class="toc-backref" href="#toc-entry-8">Contributors</a></h3>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h3><a class="toc-backref" href="#toc-entry-9">Maintainers</a></h3>
+<h2><a class="toc-backref" href="#toc-entry-9">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
@@ -526,6 +521,5 @@ <h3><a class="toc-backref" href="#toc-entry-9">Maintainers</a></h3>
 </div>
 </div>
 </div>
-</div>
 </body>
 </html>
diff --git a/l10n_it_fatturapa_in/tests/fatturapa_common.py b/l10n_it_fatturapa_in/tests/fatturapa_common.py
@@ -277,7 +277,13 @@ def create_attachment(self, name, file_name, module_name=None):
         return attach
 
     def run_wizard(
-        self, name, file_name, mode="import", wiz_values=None, module_name=None
+        self,
+        name,
+        file_name,
+        mode="import",
+        wiz_values=None,
+        module_name=None,
+        wizard_check_action="action_confirm",
     ):
         if module_name is None:
             module_name = "l10n_it_fatturapa_in"
@@ -294,7 +300,22 @@ def run_wizard(
             for wiz_field, wiz_value in wiz_values.items():
                 setattr(wizard_form, wiz_field, wiz_value)
             wizard = wizard_form.save()
-            return wizard.importFatturaPA()
+            res = wizard.importFatturaPA()
+
+            # NEW WIZARD INTERMEDIARY CREATION BASED ON VAT CHECK
+            # Case where the confirmation wizard is shown
+            if res.get("res_model") == "wizard.check.intermediary":
+
+                wizard = self.env["wizard.check.intermediary"].browse(res["res_id"])
+
+                if wizard_check_action == "action_confirm":
+                    res = wizard.action_confirm()
+                else:
+                    res = wizard.action_cancel()
+                return res
+            else:
+                return res
+
         if mode == "link":
             wizard_form = Form(
                 self.wizard_link_model.with_context(
diff --git a/l10n_it_fatturapa_in/tests/test_import_fatturapa_xml.py b/l10n_it_fatturapa_in/tests/test_import_fatturapa_xml.py
@@ -174,6 +174,33 @@ def test_05_xml_import(self):
         self.assertEqual(invoice.amount_tax, 0)
         self.assertEqual(invoice.amount_total, 9)
 
+    def test_xml_import_with_action_cancel(self):
+        partner_record = self.env["res.partner"].search([("name", "=", "MARIO ROSSI")])
+
+        if partner_record:
+            partner_record.unlink()
+
+        res = self.run_wizard(
+            "test5.2",
+            "IT05979361218_003.xml",
+            wizard_check_action="action_cancel",
+        )
+        invoice_id = res.get("domain")[0][2][0]
+        invoice = self.invoice_model.browse(invoice_id)
+        self.assertEqual(invoice.ref, "FT/2015/0008")
+        self.assertEqual(invoice.payment_reference, "FT/2015/0008")
+        self.assertEqual(invoice.sender, "TZ")
+        self.assertFalse(invoice.intermediary)
+        self.assertEqual(
+            invoice.e_invoice_line_ids[0].discount_rise_price_ids[0].name, "SC"
+        )
+        self.assertEqual(
+            invoice.e_invoice_line_ids[0].discount_rise_price_ids[0].percentage, 10
+        )
+        self.assertEqual(invoice.amount_untaxed, 9)
+        self.assertEqual(invoice.amount_tax, 0)
+        self.assertEqual(invoice.amount_total, 9)
+
     def test_06_import_except(self):
         # File not exist Exception
         self.assertRaises(Exception, self.run_wizard, "test6_Exception", "")
diff --git a/l10n_it_fatturapa_in/wizard/__init__.py b/l10n_it_fatturapa_in/wizard/__init__.py
@@ -1,2 +1,3 @@
 from . import wizard_import_fatturapa
+from . import wizard_check_intermediary_vat
 from . import link_to_existing_invoice
diff --git a/l10n_it_fatturapa_in/wizard/wizard_check_intermediary_vat.py b/l10n_it_fatturapa_in/wizard/wizard_check_intermediary_vat.py
@@ -0,0 +1,48 @@
+import json
+
+from odoo import fields, models
+
+
+class WizardCheckIntermediaryVat(models.TransientModel):
+    _name = "wizard.check.intermediary"
+    _description = "Intermediary VAT Check"
+
+    line_ids = fields.One2many(
+        comodel_name="wizard.check.intermediary.line", inverse_name="wizard_id"
+    )
+    invoice_ids = fields.Many2many(comodel_name="account.move")
+
+    def action_confirm(self):
+        for line in self.line_ids:
+            data = json.loads(line.intermediary_data_json)
+            if isinstance(data, str):
+                data = json.loads(data)
+            partner = self.env["res.partner"].create(data)
+            line.invoice_id.write({"intermediary": partner.id})
+
+        return self.action()
+
+    def action_cancel(self):
+        return self.action()
+
+    def action(self):
+        return {
+            "view_type": "form",
+            "name": "Electronic Bills",
+            "view_mode": "tree,form",
+            "res_model": "account.move",
+            "type": "ir.actions.act_window",
+            "domain": [("id", "in", self.invoice_ids.ids)],
+        }
+
+
+class WizardCheckIntermediaryVatLine(models.TransientModel):
+    _name = "wizard.check.intermediary.line"
+    _description = "Intermediary VAT Check Line"
+
+    invoice_id = fields.Many2one("account.move", string="Invoice", readonly=True)
+    firstname = fields.Char()
+    lastname = fields.Char()
+    vat = fields.Char()
+    intermediary_data_json = fields.Text()
+    wizard_id = fields.Many2one("wizard.check.intermediary")
diff --git a/l10n_it_fatturapa_in/wizard/wizard_check_intermediary_vat.xml b/l10n_it_fatturapa_in/wizard/wizard_check_intermediary_vat.xml
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <record id="view_check_intermediary_vat" model="ir.ui.view">
+        <field name="name">check.intermediary.vat.form</field>
+        <field name="model">wizard.check.intermediary</field>
+        <field name="arch" type="xml">
+            <form string="Verify Intermediary">
+                <sheet>
+                    <group>
+                        <group>
+                            <p
+                            >These intermediaries do not exist on the system. Do you want to create them?</p>
+                        </group>
+                        <field name="line_ids" nolabel="1">
+                            <tree create="0">
+                                <field name="firstname" />
+                                <field name="lastname" />
+                                <field name="vat" />
+                                <field name="invoice_id" />
+                                <field name="intermediary_data_json" invisible="1" />
+                            </tree>
+                        </field>
+                    </group>
+                    <footer>
+                        <button
+                            string="Confirm"
+                            type="object"
+                            name="action_confirm"
+                            class="btn-primary"
+                        />
+                        <button
+                            string="No"
+                            type="object"
+                            name="action_cancel"
+                            class="btn-secondary"
+                        />
+                    </footer>
+                </sheet>
+            </form>
+        </field>
+    </record>
+</odoo>
diff --git a/l10n_it_fatturapa_in/wizard/wizard_import_fatturapa.py b/l10n_it_fatturapa_in/wizard/wizard_import_fatturapa.py

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`	`1`	`from . import wizard_import_fatturapa`
	`2`	`+from . import wizard_check_intermediary_vat`
`2`	`3`	`from . import link_to_existing_invoice`