[18.0][MIG] l10n_it-financial_statements_report: Migration to 18.0

Author: micheledic

l10n_it_financial_statements_report/README.rst

@@ -17,13 +17,13 @@ ITA - Stato patrimoniale e conto economico
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github
-    :target: https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_financial_statements_report
+    :target: https://github.com/OCA/l10n-italy/tree/18.0/l10n_it_financial_statements_report
     :alt: OCA/l10n-italy
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report
+    :target: https://translation.odoo-community.org/projects/l10n-italy-18-0/l10n-italy-18-0-l10n_it_financial_statements_report
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-italy&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-italy&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -98,7 +98,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/l10n-italy/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_financial_statements_report%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_financial_statements_report%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -113,22 +113,26 @@ Authors
 Contributors
 ------------
 
-- Silvio Gregorini <https://github.com/SilvioGregorini>
-- `Ooops <https://www.ooops404.com>`__
-- `TAKOBI <https://takobi.online>`__:
+-  Silvio Gregorini <https://github.com/SilvioGregorini>
+-  `Ooops <https://www.ooops404.com>`__
+-  `TAKOBI <https://takobi.online>`__:
 
-  - Simone Rubino <sir@takobi.online>
+   -  Simone Rubino <sir@takobi.online>
 
-- `Aion Tech <https://aiontech.company/>`__:
+-  `Aion Tech <https://aiontech.company/>`__:
 
-  - Simone Rubino <simone.rubino@aion-tech.it>
+   -  Simone Rubino <simone.rubino@aion-tech.it>
+
+-  `Stesi Consulting <https://www.stesi.consulting>`__:
+
+   -  Michele Di Croce <dicroce.m@stesi.consulting>
 
 Other credits
 -------------
 
 The development of this module has been financially supported by:
 
-- Odoo Italia Network
+-  Odoo Italia Network
 
 Maintainers
 -----------
@@ -143,6 +147,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/l10n-italy <https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_financial_statements_report>`_ project on GitHub.
+This module is part of the `OCA/l10n-italy <https://github.com/OCA/l10n-italy/tree/18.0/l10n_it_financial_statements_report>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

l10n_it_financial_statements_report/__manifest__.py

@@ -2,13 +2,14 @@
 # Copyright 2019 Alessandro Camilli (alessandrocamilli@openforce.it)
 # Copyright 2019 Silvio Gregorini (silviogregorini@openforce.it)
 # Copyright 2023 Simone Rubino - Aion Tech
+# Copyright 2025 Michele Di Croce - Stesi Consulting Srl
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 {
     "name": "ITA - Stato patrimoniale e conto economico",
     "summary": "Rendicontazione .pdf e .xls per stato patrimoniale e conto"
     " economico a sezioni contrapposte",
-    "version": "16.0.1.0.5",
+    "version": "18.0.1.0.0",
     "category": "Localization/Italy",
     "author": "Odoo Community Association (OCA), Openforce",
     "website": "https://github.com/OCA/l10n-italy"
@@ -23,10 +24,4 @@
         "report/reports.xml",
         "wizard/wizard_financial_statements_report.xml",
     ],
-    "assets": {
-        "web.assets_backend": [
-            "l10n_it_financial_statements_report/static/src/js/action_manager_report.js",
-            "l10n_it_financial_statements_report/static/src/js/client_action.js",
-        ],
-    },
 }

l10n_it_financial_statements_report/migrations/16.0.1.0.1/post-migrate.py renamed to l10n_it_financial_statements_report/migrations/18.0.0.0.1/post-migrate.py

@@ -1,3 +1,3 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from . import account_account
+from . import account_account, account_group

l10n_it_financial_statements_report/models/__init__.py

@@ -36,11 +36,34 @@
         "equity",
     ],
 }
+ACCOUNT_TYPES_NEGATIVE_SIGN = [
+    "equity_unaffected",
+    "equity",
+    "income",
+    "income_other",
+    "liability_payable",
+    "liability_credit_card",
+    "asset_prepayments",
+    "liability_current",
+    "liability_non_current",
+]
 
 
 class Account(models.Model):
     _inherit = "account.account"
 
+    account_balance_sign = fields.Integer(
+        string="Balance sign", compute="_compute_account_balance_sign"
+    )
+
+    @api.depends("account_type")
+    def _compute_account_balance_sign(self):
+        for account in self:
+            if account.account_type in ACCOUNT_TYPES_NEGATIVE_SIGN:
+                account.account_balance_sign = -1
+            else:
+                account.account_balance_sign = 1
+
     # This field is almost equal to `internal_group`; yet, we wanna keep the
     # report independent from Odoo's accounting workflow, so we'll use this
     # new field for the report

l10n_it_financial_statements_report/models/account_account.py

@@ -0,0 +1,93 @@
+from odoo import fields, models
+from odoo.tools import SQL
+
+
+class AccountGroup(models.Model):
+    _inherit = "account.group"
+    account_balance_sign = fields.Integer(
+        compute="_compute_account_balance_sign",
+        string="Balance sign",
+    )
+    current_account_ids = fields.One2many(
+        "account.account", compute="_compute_current_account_ids"
+    )
+
+    def _compute_current_account_ids(self):
+        """Retrieves every account from `self` and `self`'s subgroups.
+        In Odoo 18 the group_id on account is not stored so it raises
+        an error the one2many account_ids with inverse name group_id."""
+        group_ids = self.ids
+        self.current_account_ids = self.env["account.account"]
+        if not group_ids:
+            return
+        group_ids = SQL(",".join(map(str, group_ids)))
+        results = self.env.execute_query(
+            SQL(
+                """
+SELECT
+ agroup.id AS group_id,
+STRING_AGG(DISTINCT account.id::text, ', ') as account_ids
+FROM  account_group agroup
+left join account_account account
+ON agroup.code_prefix_start <= LEFT(%(code_store)s->>%(root_company_id)s,
+char_length(agroup.code_prefix_start))
+AND agroup.code_prefix_end >= LEFT(%(code_store)s->>%(root_company_id)s,
+char_length(agroup.code_prefix_end))
+AND agroup.company_id = %(root_company_id)s
+AND agroup.id IN (%(group_ids)s)
+GROUP BY group_id
+            """,
+                code_store=SQL.identifier("account", "code_store"),
+                group_ids=group_ids,
+                root_company_id=str(self.env.company.root_id.id),
+            )
+        )
+        group_by_code = dict(results)
+        self.current_account_ids = self.env["account.account"]
+        if not group_by_code:
+            return
+        for record in self:
+            record.current_account_ids = list(
+                map(int, group_by_code.get(record.id, "").split(", "))
+            )
+
+    def _compute_account_balance_sign(self):
+        for group in self:
+            group.account_balance_sign = group.get_account_balance_sign()
+
+    def get_account_balance_sign(self):
+        self.ensure_one()
+        progenitor = self.get_group_progenitor()
+        accounts = progenitor.get_group_accounts()
+        if accounts:
+            return accounts[0].account_balance_sign
+        return 1
+
+    def get_group_accounts(self):
+        """Retrieves every account from `self` and `self`'s subgroups."""
+        return (self + self.get_group_subgroups()).mapped("current_account_ids")
+
+    def get_group_progenitor(self):
+        self.ensure_one()
+        if not self.parent_id:
+            return self
+        return self.get_group_parents().filtered(lambda g: not g.parent_id)
+
+    def get_group_parents(self):
+        """
+        Retrieves every parent for group `self`.
+        :return: group's parents as recordset, or empty recordset if `self`
+        has no parents. If a recursion is found, an error is raised.
+        """
+        self.ensure_one()
+        parent_ids = []
+        parent = self.parent_id
+        while parent:
+            parent_ids.append(parent.id)
+            parent = parent.parent_id
+        return self.browse(parent_ids)
+
+    def get_group_subgroups(self):
+        """Retrieves every subgroup for groups `self`."""
+        subgroups_ids = self.search([("id", "child_of", self.ids)])
+        return subgroups_ids

l10n_it_financial_statements_report/models/account_group.py

@@ -4,3 +4,5 @@
   - Simone Rubino \<<sir@takobi.online>\>
 - [Aion Tech](https://aiontech.company/):
   - Simone Rubino \<<simone.rubino@aion-tech.it>\>
+- [Stesi Consulting](https://www.stesi.consulting):
+  - Michele Di Croce \<<dicroce.m@stesi.consulting>\>

l10n_it_financial_statements_report/readme/CONTRIBUTORS.md

@@ -212,8 +212,8 @@ def get_column_data(self):
 
     def get_report_section(self, account=None, group=None):
         section = ""
-        if not account and group and group.account_ids:
-            account = group.account_ids[0]
+        if not account and group and group.current_account_ids:
+            account = group.current_account_ids[0]
         if account:
             section = account.financial_statements_report_section
         return section

l10n_it_financial_statements_report/report/financial_statements_report.py

@@ -598,7 +598,9 @@ def format_value_by_lang(self, lang, value=None, decimals=None):
         """Mimics `res.lang` model's `format` method"""
         percent = f"%.{decimals or 2}f"
         value = value or 0
-        return lang.format(percent, value, grouping=True, monetary=True)
+
+        lang = self.env["res.lang"].sudo().browse(lang.get("id"))
+        return lang.format(percent, value, grouping=True)
 
     def get_indent_data(self, line=None, col_dict=None):
         return col_dict.get("indent_field"), col_dict.get("indent_unit")

l10n_it_financial_statements_report/report/financial_statements_report_xlsx.py

@@ -19,7 +19,7 @@
                 <t t-call="web.external_layout">
                     <t t-set="company" t-value="o.company_id" />
                     <link
-                        href="/account_financial_report/static/src/css/report.css"
+                        href="/l10n_it_financial_statements_report/static/src/css/report.css"
                         rel="stylesheet"
                     />
                     <t