[FIX] l10n_it_fatturapa_in - Gruppi IVA #3810

SirAionTech · 2024-01-04T13:43:09Z

Risolve #1667 per 16.0.
Risolve #3146 per 16.0.

Sostituisce #3513 per risolvere #3513 (review).

Forward port di #3100.
Ho dovuto cambiare qualcosa durante il porting, soprattutto nell'ultimo commit, perché dopo #2750 non viene più sollevata un'eccezione quando vengono trovati partner duplicati.

Dipende da:

[FIX] partner_firstname: Multiple creation with "name" partner-contact#1742

francesco-ooops · 2024-08-07T10:17:22Z

@SirAionTech qualche indicazione per test funzionali?

SirAionTech · 2024-08-19T07:32:54Z

@SirAionTech qualche indicazione per test funzionali?

Sono nelle issue linkate in descrizione

Risolve #1667 per 16.0.
Risolve #3146 per 16.0.

SirAionTech · 2024-11-12T09:33:20Z

/ocabot rebase

OCA-git-bot · 2024-11-12T09:33:31Z

Congratulations, PR rebased to 16.0.

SirAionTech · 2024-11-21T10:08:58Z

@matteoopenf @eLBati magari vi interessa visto che avete revisionato #3100?

matteoopenf · 2025-02-14T10:30:13Z

se entra vediamo per fare il back port a 14 e chiudiamo quella inizialmente aperta da noi

francesco-ooops · 2025-02-14T10:44:18Z

@OCA/local-italy-maintainers buona per il merge?

OCA-git-bot · 2025-02-14T10:48:28Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

TheMule71 · 2025-03-07T09:02:39Z

l10n_it_fatturapa_in/wizard/wizard_import_fatturapa.py

+        if len(partners) > 1 and not commercial_partner:
+            found_partner = partner_model.browse()
+        elif commercial_partner:
+            commercial_partner_id = commercial_partner.id


commercial_partner_id come variabile non serve, basterebbe mettere commercial_partner.id sotto

TheMule71 · 2025-03-07T09:03:38Z

l10n_it_fatturapa_in/wizard/wizard_import_fatturapa.py

+            vals["name"] = DatiAnagrafici.Anagrafica.Denominazione
+        return vals
+
+    def getPartnerBase(self, DatiAnagrafici):  # noqa: C901


# noqa: C901 probabilmente adesso dopo il refactoring non serve piu

matteoopenf · 2025-04-24T10:26:59Z

@SirPyTech per caso riesci a fare i cambiamenti mi sembra che sia il tuo nuovo nick dopo @SirAionTech
Grazie Mille

SirPyTech · 2025-04-24T10:39:06Z

@SirPyTech per caso riesci a fare i cambiamenti mi sembra che sia il tuo nuovo nick dopo @SirAionTech Grazie Mille

Sì è il nuovo nick, però non è detto che io possa seguire i lavori fatti con i vecchi account.

Consiglio di trattare @SirAionTech come se fosse un account disattivato (di fatto lo è): se ci sono modifiche da fare qualcuno dovrà sostituire la PR, ovviamente rispettando l'authorship e quant'altro.
Può capitare che lo faccia io, ma come me possono farlo anche altri contributors.

matteoopenf · 2025-04-24T10:40:28Z

@SirPyTech per caso riesci a fare i cambiamenti mi sembra che sia il tuo nuovo nick dopo @SirAionTech Grazie Mille

Sì è il nuovo nick, però non è detto che io possa seguire i lavori fatti con i vecchi account.

Consiglio di trattare @SirAionTech come se fosse un account disattivato (di fatto lo è): se ci sono modifiche da fare qualcuno dovrà sostituire la PR, ovviamente rispettando l'authorship e quant'altro. Può capitare che lo faccia io, ma come me possono farlo anche altri contributors.

ok

matteoopenf · 2025-06-12T17:14:24Z

@TheMule71 sono mandatorie le modifiche che hai chiesto? o potremmo comunque mergiare?

monen17

Grazie @TheMule71 della revisione, ho fatto le modifiche che suggeristi.
Secondo me comunque non erano bloccanti per il merge.
Puoi vedere se ora va meglio?

Ho anche risolto i conflitti.

monen17 · 2025-08-24T09:28:25Z

l10n_it_fatturapa_in/wizard/wizard_import_fatturapa.py

+        if len(partners) > 1 and not commercial_partner:
+            found_partner = partner_model.browse()
+        elif commercial_partner:
+            commercial_partner_id = commercial_partner.id


monen17 · 2025-08-24T09:29:36Z

l10n_it_fatturapa_in/wizard/wizard_import_fatturapa.py

+            vals["name"] = DatiAnagrafici.Anagrafica.Denominazione
+        return vals
+
+    def getPartnerBase(self, DatiAnagrafici):  # noqa: C901


monen17 · 2025-08-24T09:39:10Z

I test non partono per #4519 (comment).

francesco-ooops · 2025-08-29T13:51:44Z

/ocabot rebase

Co-authored-by: SirAionTech <simone.rubino@aion-tech.it>

Extract commercial partner retrieval Extract partner search Use the actual domain from multi-company partners sharing rule Co-authored-by: SirAionTech <simone.rubino@aion-tech.it>

Co-authored-by: SirAionTech <simone.rubino@aion-tech.it>

Only CedentePrestatore and CessionarioCommittente are checked for VAT Groups, when other partner fields match multiple partners just log an inconsistency Co-authored-by: SirAionTech <simone.rubino@aion-tech.it>

OCA-git-bot · 2025-08-29T13:51:55Z

Congratulations, PR rebased to 16.0.

Before this change, the test finds two different partners with two different commercial partners that are created by other tests so no supplier is assigned to the created bill

francesco-ooops mentioned this pull request Jan 4, 2024

Gruppi IVA #1667

Open

5 tasks

francesco-ooops linked an issue Jan 4, 2024 that may be closed by this pull request

Gruppi IVA #1667

Open

5 tasks

francesco-ooops mentioned this pull request Jan 4, 2024

Importazione fattura elettronica con terzo intermediario in Gruppo IVA #3146

Open

3 tasks

francesco-ooops linked an issue Jan 4, 2024 that may be closed by this pull request

Importazione fattura elettronica con terzo intermediario in Gruppo IVA #3146

Open

3 tasks

This comment was marked as resolved.

Sign in to view

SirAionTech marked this pull request as ready for review January 4, 2024 13:56

SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from c34d69a to dc72f06 Compare January 26, 2024 10:26

SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from dc72f06 to fa95da5 Compare March 1, 2024 15:36

SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from fa95da5 to 639eecc Compare April 19, 2024 13:33

SirAionTech marked this pull request as draft April 19, 2024 14:29

SirAionTech marked this pull request as ready for review April 22, 2024 09:05

SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from 499df25 to 639eecc Compare May 31, 2024 07:25

SirAionTech marked this pull request as draft May 31, 2024 07:54

SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from 639eecc to acb7371 Compare May 31, 2024 08:00

SirAionTech mentioned this pull request May 31, 2024

[14.0][FIX] l10n_it_fatturapa_in: test improvement #3479

Closed

SirAionTech marked this pull request as ready for review May 31, 2024 09:54

SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch 3 times, most recently from cb98726 to 4d74656 Compare May 31, 2024 09:58

SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from 4d74656 to 6934f6d Compare August 6, 2024 11:06

SirAionTech marked this pull request as draft August 6, 2024 12:04

SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from 6934f6d to f3c7e04 Compare August 6, 2024 13:27

SirAionTech marked this pull request as ready for review August 6, 2024 13:53

SirAionTech added the is porting This pull request is porting a change from another version label Nov 11, 2024

OCA-git-bot force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from f3c7e04 to b67afbf Compare November 12, 2024 09:33

matteoopenf approved these changes Feb 14, 2025

View reviewed changes

OCA-git-bot added the approved label Feb 14, 2025

OCA-git-bot added the ready to merge label Feb 14, 2025

TheMule71 reviewed Mar 7, 2025

View reviewed changes

matteoopenf mentioned this pull request Apr 7, 2025

[IMP] l10n_it_fatturapa_in: additionally filter by fiscalcode when more than one partner with same vat but different fiscalcode #4692

Open

SirPyTech mentioned this pull request Apr 14, 2025

[14.0][IMP] l10n_it_fatturapa_in: intermediary contact creation depending by vat #4621

Open

monen17 force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch 2 times, most recently from ced0e78 to 5d960a0 Compare August 24, 2025 09:34

monen17 requested a review from TheMule71 August 24, 2025 09:35

monen17 reviewed Aug 24, 2025

View reviewed changes

monen17 requested review from monen17 and removed request for monen17 August 24, 2025 09:40

SirTakobi and others added 5 commits August 29, 2025 13:51

[COV] l10n_it_fatturapa_in: Error when there are multiple partners

0472899

Co-authored-by: SirAionTech <simone.rubino@aion-tech.it>

[REF] l10n_it_fatturapa_in: Include partners in error message

f42b670

Extract commercial partner retrieval Extract partner search Use the actual domain from multi-company partners sharing rule Co-authored-by: SirAionTech <simone.rubino@aion-tech.it>

[FIX] l10n_it_fatturapa_in: Manage VAT groups

ecd5b31

Co-authored-by: SirAionTech <simone.rubino@aion-tech.it>

[IMP] l10n_it_fatturapa_in: Skip Duplicated Partners for some fields

5a276f3

Only CedentePrestatore and CessionarioCommittente are checked for VAT Groups, when other partner fields match multiple partners just log an inconsistency Co-authored-by: SirAionTech <simone.rubino@aion-tech.it>

[COV] l10n_it_fatturapa_in: Do not depend on previous tests

4133f97

OCA-git-bot force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from 5d960a0 to 4133f97 Compare August 29, 2025 13:51

[IMP] l10n_it_fatturapa_in: Remove tests dependency

512da02

Before this change, the test finds two different partners with two different commercial partners that are created by other tests so no supplier is assigned to the created bill

Uh oh!

[FIX] l10n_it_fatturapa_in - Gruppi IVA #3810

Are you sure you want to change the base?

[FIX] l10n_it_fatturapa_in - Gruppi IVA #3810

Uh oh!

Conversation

SirAionTech commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

francesco-ooops commented Aug 7, 2024

Uh oh!

SirAionTech commented Aug 19, 2024

Uh oh!

SirAionTech commented Nov 12, 2024

Uh oh!

OCA-git-bot commented Nov 12, 2024

Uh oh!

SirAionTech commented Nov 21, 2024

Uh oh!

matteoopenf commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francesco-ooops commented Feb 14, 2025

Uh oh!

OCA-git-bot commented Feb 14, 2025

Uh oh!

TheMule71 Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

monen17 Aug 24, 2025

Choose a reason for hiding this comment

Uh oh!

TheMule71 Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

monen17 Aug 24, 2025

Choose a reason for hiding this comment

Uh oh!

matteoopenf commented Apr 24, 2025

Uh oh!

SirPyTech commented Apr 24, 2025

Uh oh!

matteoopenf commented Apr 24, 2025

Uh oh!

matteoopenf commented Jun 12, 2025

Uh oh!

monen17 left a comment

Choose a reason for hiding this comment

Uh oh!

monen17 Aug 24, 2025

Choose a reason for hiding this comment

Uh oh!

monen17 Aug 24, 2025

Choose a reason for hiding this comment

Uh oh!

monen17 commented Aug 24, 2025

Uh oh!

francesco-ooops commented Aug 29, 2025

Uh oh!

OCA-git-bot commented Aug 29, 2025

Uh oh!

Uh oh!

SirAionTech commented Jan 4, 2024 •

edited

Loading

matteoopenf commented Feb 14, 2025 •

edited

Loading