[16.0] [FIX] l10n_withholding_tax: fix the amount_net_pay_residual value compute and reconciled withholding tax move #4906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
value and search of withholding tax move In case of a payment where the amount is comprehensive of multiple supplier invoice, the amount_net_pay_residual value become negative in supplier invoice even if amount net pay is zero; In case a payment is composed by multiple invoices, the actual logic get the first account.move.line that has the id of payment move in the withholdint_tax_generted_by_move_id set with the id of payment move, this PR allow to filter that lines by partner to be sure to get the right account.move.line
patrickt-oforce
force-pushed
the
16.0-FIX-l10n_it_withholding_tax
branch
from
b551a0b to
073ba0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a supplier invoice payment amount is major than
amount_net_pay_residualthe value compute became negative, so to avoid that check if the payment amount is greater than invoice amount_net_pay_residual and if it is, assign the residual amount to amount variable to allow show 0 when the invoice is fully paidWhen the supplier invoice is reconciled with a multiple line payment, not filtering by partner get the wrong withholding tax move id, becuase actually the only search parameter is the move that has generated the withholding tax move.
This PR add filter account.move.line of withholding tax move by partner to avoid get the first account.move.line where value of
withholding_tax_generated_by_move_idmatch the payment move even if the line belongs to another partner