[16.0][FIX] auth_api_key: Use 401 for unauthorized user

[anusriNPS]

As per documentation, using 401 as status code seems valid for a user who is not able to be authorized. However, 403 is used for scenario where user is forbidden to access a resource. So, returning 401 instead of 403.

[HekkiMelody]

This is the same change as #629 , I think it makes sense here as it did there.

LGTM

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[HekkiMelody]

@OCA/tools-maintainers Hello, this is a tiny fix to be more compliant with expectations of a REST architecture, we've been using it in production for a few months now, can it be merged? Thanks

[LoisRForgeFlow]

LGTM

[LoisRForgeFlow]

There is no declared maintainer of the module so I'm merging...

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-738-by-LoisRForgeFlow-bump-patch, awaiting test results.

[HekkiMelody]

Thank you @LoisRForgeFlow !

[OCA-git-bot]

Congratulations, your PR was merged at cfb1526. Thanks a lot for contributing to OCA. ❤️

[LoisRForgeFlow]

@aleuffre no problem! Could you take care of fwporting the fix to 17 and 18? ping me on the PR and we can quickly merge

[simahawk]

@anusriNPS @aleuffre thanks for your contrib!
Next time please, respect commit convention by removing the odoo version.
I see that in the fwd ports, the commit msg has been rewritten to match the odoo version: we shouldn't do it.
If you drop the version in the original commit, there's nothing to fix afterwards 😉

[HekkiMelody]

@anusriNPS @aleuffre thanks for your contrib! Next time please, respect commit convention by removing the odoo version. I see that in the fwd ports, the commit msg has been rewritten to match the odoo version: we shouldn't do it. If you drop the version in the original commit, there's nothing to fix afterwards 😉

You're right, I missed it when reviewing, apologies

[anusriNPS]

@anusriNPS @aleuffre thanks for your contrib! Next time please, respect commit convention by removing the odoo version. I see that in the fwd ports, the commit msg has been rewritten to match the odoo version: we shouldn't do it. If you drop the version in the original commit, there's nothing to fix afterwards 😉

Sure, will take care to align with Odoo convention in upcoming commits.