[18.0][FIX] auth_api_key: Use 401 for unauthorized user#806
Merged
OCA-git-bot merged 1 commit intoOCA:18.0from Jun 16, 2025
Merged
[18.0][FIX] auth_api_key: Use 401 for unauthorized user#806OCA-git-bot merged 1 commit intoOCA:18.0from
OCA-git-bot merged 1 commit intoOCA:18.0from
Conversation
anusriNPS
force-pushed
the
18.0-fix-server_auth_wrong_code
branch
from
d22daf0 to
e4a9157
Compare
Contributor
Author
|
@LoisRForgeFlow , this port-forward for 18.0 is ready. Could you please help to merge it? |
LoisRForgeFlow
approved these changes
Jun 16, 2025
LoisRForgeFlow
left a comment
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
Straight forward fwport
/ocabot merge patch
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at cf63045. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port forward fix from 16.0 #738
As per documentation, using 401 as status code seems valid for a user who is not able to be authorized. However, 403 is used for scenario where user is forbidden to access a resource. So, returning 401 instead of 403.