[16.0][FIX]hr_timesheet_sheet_autodraft: fix department in timesheet sheet #786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an employee requests some time-off, timesheet sheet is created if it doesn't exist, but sometimes department could be set wrong. By default, it's set with the same department of who approves time-off.
This is not correct, so my fix set department as the same of the employee who requested time-off.
These are the steps to reproduce the bug:
hr_timesheet_sheet_autodraft
should be active and Auto-draft Timesheet setting should be checked;On approval, a new timesheet will be created for employee 1 with the department of employee 2.
With this fix, timesheet will be created with department of employee 1.