Skip to content

[16.0][FIX]hr_timesheet_sheet_autodraft: fix department in timesheet sheet #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FIX]hr_timesheet_sheet_autodraft: fix department in timesheet sheet #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hr_timesheet_sheet_autodraft/models/account_analytic_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def _get_autodraft_sheet_values(self):
self.company_id, self.date
),
"date_end": HrTimesheetSheet._get_period_end(self.company_id, self.date),
"department_id": self.employee_id.department_id.id,
}

def action_autodraft_timesheet_sheets(self):
Expand Down
7 changes: 6 additions & 1 deletion hr_timesheet_sheet_autodraft/tests/test_hr_timesheet_sheet_autodraft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ def setUp(self):
self.ResUsers = self.env["res.users"]
self.Company = self.env["res.company"]
self.Project = self.env["project.project"]
self.HrDepartment = self.env["hr.department"]
self.HrEmployee = self.env["hr.employee"]
self.HrTimesheetSheet = self.env["hr_timesheet.sheet"]
self.AccountAnalyticLine = self.env["account.analytic.line"]
Expand Down Expand Up @@ -43,7 +44,10 @@ def test_autocreate(self):
"company_id": self.company_id.id,
}
)
employee = self.HrEmployee.create({"name": "Employee", "user_id": user.id})
department = self.HrDepartment.create({"name": "Department 1"})
employee = self.HrEmployee.create(
{"name": "Employee", "user_id": user.id, "department_id": department.id}
)
project = self.Project.create({"name": "Project"})

aal_1 = self.AccountAnalyticLine.create(
Expand All @@ -67,6 +71,7 @@ def test_autocreate(self):
self.assertTrue(aal_1.sheet_id)
self.assertTrue(aal_2.sheet_id)
self.assertEqual(aal_1.sheet_id, aal_2.sheet_id)
self.assertEqual(aal_1.sheet_id.department_id, employee.department_id)

def test_already_confirmed(self):
user = self.ResUsers.sudo().create(
Expand Down