add many2many support for draft

Author: yostashiro

web_form_banner/README.rst

@@ -73,7 +73,7 @@ Evaluation context variables available in Message Value Code:
   form's unsaved changes) + the current unsaved changes on trigger fields.
   Should be used instead of `record` when your rule is triggered dynamically by an
   update to a trigger field. It doesn't include any values from complex fields
-  (x2many/reference, etc).
+  (one2many/reference, etc).
 * `record_id`: Integer id of the record being edited, or `False` if the form
   is creating a new record.
 * `model`: Shortcut to the current model (`env[record._name]`).
@@ -221,8 +221,8 @@ Limitations of `draft` eval context variable
   persisted record; all other fields come from `Model.new` defaults rather than the
   database.
 * Only simple field types are included: `char`, `text`, `html`, `selection`, `boolean`,
-  `integer`, `float`, `monetary`, `date`, `datetime`, and `many2one` (normalized to an
-  integer ID). **x2many/reference/other types are omitted.**
+  `integer`, `float`, `monetary`, `date`, `datetime`, `many2one`, and `many2many`.
+  **one2many/reference/other types are omitted.**
 
 Bug Tracker
 ===========

web_form_banner/models/web_form_banner_rule.py

@@ -30,28 +30,60 @@
 
 
 def _extract_m2o_id(v):
-    """Normalize many2one values to an integer id or False.
-    Accepts: int, (id, ...) tuple/list, or dict with id-ish keys.
-    """
+    """Normalize many2one values to an integer id or False."""
     if isinstance(v, int):
         return v
     if isinstance(v, (list, tuple)) and v and isinstance(v[0], int):
         return v[0]
     if isinstance(v, dict):
-        data = v.get("data") or {}
-        return v.get("res_id") or data.get("id") or v.get("id") or v.get("ref") or False
+        m2o_id = v.get("res_id") or v.get("id")
+        if isinstance(m2o_id, int):
+            return m2o_id
     return False
 
 
+def _m2m_items(value):
+    if isinstance(value, (list, tuple)):
+        return value
+    if isinstance(value, dict):
+        if isinstance(value.get("res_ids"), (list, tuple)):
+            return value["res_ids"]
+        if isinstance(value.get("data"), (list, tuple)):
+            return value["data"]
+    return None
+
+
+def _to_int_id(e):
+    if isinstance(e, int):
+        return e
+    if isinstance(e, str) and e.isdigit():
+        return int(e)
+    if isinstance(e, dict):
+        rid = e.get("res_id")
+        if isinstance(rid, int):
+            return rid
+        iid = e.get("id")
+        if isinstance(iid, int):
+            return iid
+    return None
+
+
 def _sanitize_field(field, value):
     """Return sanitized value for a single field, or None to skip."""
     if not field:
         return None
     if field.type == "many2one":
         return _extract_m2o_id(value)
+    if field.type == "many2many":
+        items = _m2m_items(value)
+        if items is None:
+            return None
+        ids = [i for i in (_to_int_id(e) for e in items) if i is not None]
+        # Always return a command, even when empty, to reflect clearing the relation
+        return [(6, 0, ids)]
     if field.type in _SIMPLE_FIELD_TYPES:
         return value
-    return None  # skip x2many/reference/others
+    return None  # skip one2many/reference/others
 
 
 class WebFormBannerRule(models.Model):

web_form_banner/readme/ROADMAP.rst

@@ -13,5 +13,5 @@ Limitations of `draft` eval context variable
   persisted record; all other fields come from `Model.new` defaults rather than the
   database.
 * Only simple field types are included: `char`, `text`, `html`, `selection`, `boolean`,
-  `integer`, `float`, `monetary`, `date`, `datetime`, and `many2one` (normalized to an
-  integer ID). **x2many/reference/other types are omitted.**
+  `integer`, `float`, `monetary`, `date`, `datetime`, `many2one`, and `many2many`.
+  **one2many/reference/other types are omitted.**

web_form_banner/readme/USAGE.rst

@@ -29,7 +29,7 @@ Evaluation context variables available in Message Value Code:
   form's unsaved changes) + the current unsaved changes on trigger fields.
   Should be used instead of `record` when your rule is triggered dynamically by an
   update to a trigger field. It doesn't include any values from complex fields
-  (x2many/reference, etc).
+  (one2many/reference, etc).
 * `record_id`: Integer id of the record being edited, or `False` if the form
   is creating a new record.
 * `model`: Shortcut to the current model (`env[record._name]`).

web_form_banner/static/description/index.html

@@ -433,7 +433,7 @@ <h2><a class="toc-backref" href="#id3">Evaluation context variables available in
 form’s unsaved changes) + the current unsaved changes on trigger fields.
 Should be used instead of <cite>record</cite> when your rule is triggered dynamically by an
 update to a trigger field. It doesn’t include any values from complex fields
-(x2many/reference, etc).</li>
+(one2many/reference, etc).</li>
 <li><cite>record_id</cite>: Integer id of the record being edited, or <cite>False</cite> if the form
 is creating a new record.</li>
 <li><cite>model</cite>: Shortcut to the current model (<cite>env[record._name]</cite>).</li>
@@ -568,8 +568,8 @@ <h2><a class="toc-backref" href="#id8">Limitations of <cite>draft</cite> eval co
 persisted record; all other fields come from <cite>Model.new</cite> defaults rather than the
 database.</li>
 <li>Only simple field types are included: <cite>char</cite>, <cite>text</cite>, <cite>html</cite>, <cite>selection</cite>, <cite>boolean</cite>,
-<cite>integer</cite>, <cite>float</cite>, <cite>monetary</cite>, <cite>date</cite>, <cite>datetime</cite>, and <cite>many2one</cite> (normalized to an
-integer ID). <strong>x2many/reference/other types are omitted.</strong></li>
+<cite>integer</cite>, <cite>float</cite>, <cite>monetary</cite>, <cite>date</cite>, <cite>datetime</cite>, <cite>many2one</cite>, and <cite>many2many</cite>.
+<strong>one2many/reference/other types are omitted.</strong></li>
 </ul>
 </div>
 </div>

web_form_banner/static/src/js/web_form_banner.js

@@ -35,14 +35,16 @@ odoo.define("web_form_banner.save_plus_load", function (require) {
         if (p && typeof p.always === "function") { p.always(fn); return p; }
         return Promise.resolve(p).finally(fn);
     };
-    // keep only primitives + many2one record ids
     var shrinkDraft = function (d) {
         return Object.entries(d || {}).reduce(function (o, kv) {
             var k = kv[0], v = kv[1], t = typeof v;
             if (v == null || t === "string" || t === "number" || t === "boolean") {
                 o[k] = v;
             } else if (v && v.type === "record" && typeof v.res_id === "number") {
                 o[k] = v.res_id;
+            } else if (Array.isArray(v) || (v && (Array.isArray(v.data) || Array.isArray(v.res_ids)))) {
+                // many2many (and possibly other x2many) values; let Python decide
+                o[k] = v;
             }
             return o;
         }, {});
@@ -149,7 +151,6 @@ odoo.define("web_form_banner.save_plus_load", function (require) {
         update: function () {
             return withRefresh(this, this._super, arguments);
         },
-
         // onchange: refresh only when a declared trigger actually changed
         _onFieldChanged: function (ev) {
             var res = this._super.apply(this, arguments);
@@ -162,13 +163,11 @@ odoo.define("web_form_banner.save_plus_load", function (require) {
             after(res, () => refreshBanners(this));
             return res;
         },
-
         activate: function () {
             var res = this._super.apply(this, arguments);
             if (hasBanners(this)) after(res, () => refreshBanners(this));
             return res;
         },
-
         on_attach_callback: function () {
             this._super.apply(this, arguments);
             setTimeout(() => refreshBanners(this));