[MIG] web_form_banner: Migration to 15.0

Author: AungKoKoLin1997

web_form_banner/__manifest__.py

@@ -2,17 +2,22 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 {
     "name": "Web Form Banner",
-    "version": "12.0.1.0.0",
+    "version": "15.0.1.0.0",
     "category": "Web",
     "author": "Quartile, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/web",
     "license": "AGPL-3",
     "depends": ["web"],
     "data": [
         "security/ir.model.access.csv",
-        "views/assets.xml",
         "views/web_form_banner_rule_views.xml",
     ],
+    "assets": {
+        "web.assets_backend": [
+            "web_form_banner/static/src/js/*.esm.js",
+            "web_form_banner/static/src/scss/*.scss",
+        ],
+    },
     "demo": ["demo/web_form_banner_rule_demo.xml"],
     "installable": True,
 }

web_form_banner/models/web_form_banner_rule.py

@@ -1,8 +1,6 @@
 # Copyright 2025 Quartile (https://www.quartile.co)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-import datetime as dt
-import time
 from functools import lru_cache
 from string import Template
 
@@ -13,9 +11,8 @@
 
 from odoo import _, api, fields, models
 from odoo.exceptions import ValidationError
-from odoo.tools import html_escape
+from odoo.tools import html_escape, safe_eval
 from odoo.tools.float_utils import float_compare, float_is_zero, float_round
-from odoo.tools.safe_eval import safe_eval
 
 
 class WebFormBannerRule(models.Model):
@@ -39,7 +36,6 @@ class WebFormBannerRule(models.Model):
     )
     position = fields.Selection(
         [("before", "Before target"), ("after", "After target")],
-        string="Position",
         default="before",
         required=True,
         help="Where to insert the placeholder relative to the first matched node.",
@@ -75,7 +71,7 @@ def _check_target_xpath(self):
             try:
                 etree.XPath(xp or "//sheet")
             except (etree.XPathSyntaxError, etree.XPathEvalError) as e:
-                raise ValidationError(_("Invalid XPath:\n%s") % e)
+                raise ValidationError(_("Invalid XPath:\n%s") % e) from e
 
     @api.model
     def _build_form_url(self, rec):
@@ -95,8 +91,8 @@ def _build_form_url(self, rec):
     def _banner_base_eval_ctx_static(self):
         # Only static, import-heavy items
         return {
-            "time": time,
-            "datetime": dt,
+            "time": safe_eval.time,
+            "datetime": safe_eval.datetime,
             "dateutil": {
                 "parser": dateparse,
                 "relativedelta": relativedelta,
@@ -143,10 +139,10 @@ def compute_message(self, rule_id, model, res_id):
             code = rule.message_value_code.strip()
             try:
                 # 1) try single-expression dict
-                out = safe_eval(code, eval_ctx, mode="eval") or {}
+                out = safe_eval.safe_eval(code, eval_ctx, mode="eval") or {}
             except Exception:
                 # 2) allow multi-line; expect `result` to be set
-                safe_eval(code, eval_ctx, mode="exec", nocopy=True)
+                safe_eval.safe_eval(code, eval_ctx, mode="exec", nocopy=True)
                 out = eval_ctx.get("result") or {}
             if not isinstance(out, dict):
                 return {"visible": False}

web_form_banner/static/src/js/web_form_banner.js renamed to web_form_banner/static/src/js/web_form_banner.esm.js

@@ -1,14 +1,29 @@
 odoo.define("web_form_banner.save_plus_load", function (require) {
-    "use strict";
     var rpc = require("web.rpc");
     var FormController = require("web.FormController");
 
+    function placeBannerAsFullRow($b, position) {
+        var $td = $b.closest("td");
+        var $tr = $td.closest("tr");
+        if (!$tr.length) {
+            return false;
+        }
+        // Create new row spanning both label+value columns
+        var $row = $('<tr class="o_wfb_fullrow"><td colspan="2"></td></tr>');
+        $row.find("td").append($b); // Detach + reinsert banner
+        if (position === "before") {
+            $tr.before($row);
+        } else {
+            $tr.after($row);
+        }
+        return true;
+    }
+
     function refreshBanners(ctrl) {
         var $banners = ctrl.$('.o_form_view div[role="alert"][data-rule-id]');
         var state = ctrl.model.get(ctrl.handle);
         var resId = state && state.res_id;
         if (!resId || !$banners.length) return;
-
         $banners.each(function () {
             var $b = $(this);
             var ruleId = parseInt($b.data("rule-id") || $b.data("wfb-rule-id"));
@@ -35,31 +50,34 @@ odoo.define("web_form_banner.save_plus_load", function (require) {
                 } else {
                     $b.html(html);
                 }
+                if ($b.closest("table.o_group").length) {
+                    var pos = $b.data("insert-pos") || "after";
+                    placeBannerAsFullRow($b, pos);
+                }
                 $b.show();
             });
         });
     }
 
+    function withRefresh(ctrl, superFn, args) {
+        var p = superFn.apply(ctrl, args);
+        return p.then(function () {
+            refreshBanners(ctrl);
+        });
+    }
+
     FormController.include({
         start: function () {
-            var p = this._super.apply(this, arguments);
-            var self = this;
-            return p.then(function () {
-                refreshBanners(self);
-            });
+            return withRefresh(this, this._super, arguments);
         },
         reload: function () {
-            var p = this._super.apply(this, arguments);
-            var self = this;
-            return p.then(function () {
-                refreshBanners(self);
-            });
+            return withRefresh(this, this._super, arguments);
         },
         saveRecord: function () {
-            var self = this;
-            return this._super.apply(this, arguments).then(function () {
-                refreshBanners(self);
-            });
+            return withRefresh(this, this._super, arguments);
+        },
+        update: function (params, options) {
+            return withRefresh(this, this._super, arguments);
         },
     });
 });

web_form_banner/tests/test_web_form_banner.py

@@ -3,11 +3,11 @@
 
 from lxml import etree
 
-from odoo.tests.common import SavepointCase, tagged
+from odoo.tests.common import TransactionCase, tagged
 
 
 @tagged("post_install", "-at_install")
-class TestFieldsViewGetPartnerBanner(SavepointCase):
+class TestFieldsViewGetPartnerBanner(TransactionCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
@@ -23,7 +23,6 @@ def setUpClass(cls):
                 "but none was found. Ensure demo data is loaded."
             )
         cls.partner_form_view = cls.env.ref("base.view_partner_form")
-
         cls.p_len3 = cls.Partner.create({"name": "Bob"})  # 3
         cls.p_len12 = cls.Partner.create({"name": "Yoshi Tashiro"})  # 12
         cls.p_len22 = cls.Partner.create({"name": "Professor Charles Xavier"})  # 22