[MIG] web_form_banner: Migration to 15.0

Author: AungKoKoLin1997

web_form_banner/__manifest__.py

@@ -2,17 +2,22 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 {
     "name": "Web Form Banner",
-    "version": "12.0.1.0.0",
+    "version": "15.0.1.0.0",
     "category": "Web",
     "author": "Quartile, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/web",
     "license": "AGPL-3",
     "depends": ["web"],
     "data": [
         "security/ir.model.access.csv",
-        "views/assets.xml",
         "views/web_form_banner_rule_views.xml",
     ],
+    "assets": {
+        "web.assets_backend": [
+            "web_form_banner/static/src/js/*.esm.js",
+            "web_form_banner/static/src/scss/*.scss",
+        ],
+    },
     "demo": ["demo/web_form_banner_rule_demo.xml"],
     "installable": True,
 }

web_form_banner/models/web_form_banner_rule.py

@@ -1,9 +1,7 @@
 # Copyright 2025 Quartile (https://www.quartile.co)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-import datetime as dt
 import logging
-import time
 from functools import lru_cache
 from string import Template
 
@@ -14,9 +12,8 @@
 
 from odoo import _, api, fields, models
 from odoo.exceptions import ValidationError
-from odoo.tools import html_escape
+from odoo.tools import html_escape, safe_eval
 from odoo.tools.float_utils import float_compare, float_is_zero, float_round
-from odoo.tools.safe_eval import safe_eval
 
 _logger = logging.getLogger(__name__)
 
@@ -115,7 +112,6 @@ class WebFormBannerRule(models.Model):
     )
     position = fields.Selection(
         [("before", "Before target"), ("after", "After target")],
-        string="Position",
         default="before",
         required=True,
         help="Where to insert the placeholder relative to the first matched node.",
@@ -158,7 +154,7 @@ def _check_target_xpath(self):
             try:
                 etree.XPath(xp or "//sheet")
             except (etree.XPathSyntaxError, etree.XPathEvalError) as e:
-                raise ValidationError(_("Invalid XPath:\n%s") % e)
+                raise ValidationError(_("Invalid XPath:\n%s") % e) from e
 
     @api.model
     def _build_form_url(self, rec):
@@ -179,8 +175,8 @@ def _build_form_url(self, rec):
     def _base_eval_ctx_static(self):
         # Only static, import-heavy items
         return {
-            "time": time,
-            "datetime": dt,
+            "time": safe_eval.time,
+            "datetime": safe_eval.datetime,
             "dateutil": {
                 "parser": dateparse,
                 "relativedelta": relativedelta,
@@ -240,9 +236,9 @@ def _run_rule_code(self, rule, eval_ctx):
             return {}
         code = rule.message_value_code.strip()
         try:
-            out = safe_eval(code, eval_ctx, mode="eval") or {}
+            out = safe_eval.safe_eval(code, eval_ctx, mode="eval") or {}
         except Exception:
-            safe_eval(code, eval_ctx, mode="exec", nocopy=True)
+            safe_eval.safe_eval(code, eval_ctx, mode="exec", nocopy=True)
             out = eval_ctx.get("result") or {}
         return out if isinstance(out, dict) else {}
 

web_form_banner/static/src/js/web_form_banner.js renamed to web_form_banner/static/src/js/web_form_banner.esm.js

@@ -1,5 +1,5 @@
 odoo.define("web_form_banner.save_plus_load", function (require) {
-    "use strict";
+
     var rpc = require("web.rpc");
     var FormController = require("web.FormController");
 
@@ -129,6 +129,16 @@ odoo.define("web_form_banner.save_plus_load", function (require) {
                         else elRef.innerHTML = "";
                         return;
                     }
+                    console.log(
+                        "Banner",
+                        ruleId,
+                        "on",
+                        model,
+                        resId,
+                        formVals,
+                        "→",
+                        res
+                    );
                     var sev = first(
                         res.severity,
                         elRef.dataset.defaultSeverity,

web_form_banner/tests/test_web_form_banner.py

@@ -20,7 +20,6 @@ def setUpClass(cls):
         cls.rule_email.active = False
         cls.rule_tag.active = False
         cls.partner_form_view = cls.env.ref("base.view_partner_form")
-
         cls.p_len3 = cls.Partner.create({"name": "Bob"})  # 3
         cls.p_len12 = cls.Partner.create({"name": "Yoshi Tashiro"})  # 12
         cls.p_len22 = cls.Partner.create({"name": "Professor Charles Xavier"})  # 22