Skip to content

Conversation

julienCozo
Copy link

Migration to 18.0

@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

@julienCozo julienCozo force-pushed the 18.0-mig-web-save-discard-button branch from 5b80b1b to d6b1104 Compare August 4, 2025 14:15
@julienCozo
Copy link
Author

Hello @pedrobaeza ,
My bad, it should be nice now.
Thank you

@pedrobaeza
Copy link
Member

/ocabot migration web_save_discard_button

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 4, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 4, 2025
45 tasks
Copy link
Contributor

@remi-filament remi-filament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julienCozo tested OK on Runboat

@innovara
Copy link

innovara commented Sep 5, 2025

Functional tests are okay for me but there are still a number of references to 17.0 particularly in web_save_discard_button/static/description/index.html and web_save_discard_button/README.rst.
I've done a migration myself but it wouldn't be appropriate to open another PR. See here: https://github.com/innovara/web/tree/18.0-mig-web_save_discard_button

@julienCozo
Copy link
Author

thank you @innovara. I made the fix

@R4Alex
Copy link

R4Alex commented Sep 24, 2025

@julienCozo @pedrobaeza

Is there any way to unlock this PR? It would be super cool to have already this module in 18.0

@pedrobaeza
Copy link
Member

@R4Alex do the review on the PR: https://odoo-community.org/resources/review

@innovara
Copy link

@julienCozo I think commit [FIX] remove 17.0 references should be a fixup of the migration commit. It's all part of the migration.

Copy link

@innovara innovara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last commit fixing references to 17.0 should just be part of the migration commit. Otherwise, LGTM. Functionality tested in runboat and in my own test environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.