Skip to content

[15.0][FIX] web_widget_url_advanced-rende: allow url widget to display text from another field fails when filed is not readonly #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][FIX] web_widget_url_advanced-rende: allow url widget to display text from another field fails when filed is not readonly #3278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions web_widget_url_advanced/static/src/js/url_widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ odoo.define("web_widget_url_advanced", function (require) {
_get_text: function () {
if (this.text_field) {
var field_value = this.recordData[this.text_field];
if (_.isObject(field_value) && _.has(field_value.data)) {
if (_.isObject(field_value) && _.has(field_value, "data")) {
field_value = field_value.data.display_name;
}
return field_value;
Expand All @@ -37,13 +37,14 @@ odoo.define("web_widget_url_advanced", function (require) {
_renderReadonly: function () {
// Base widget uses `this.attrs.text` instead of `this.value` when available.
// TODO: To check better way for update link
this.attrs.text = this._get_text();
this._super.apply(this, arguments);
var $link = this.$el.is("a") ? this.$el : this.$el.find("a");
if ($link.length) {
$link.text(this._get_text() || this.value || "");
}
var prefix = this.attrs.prefix_name || this.attrs.options.prefix_name;
if (prefix) {
this.$el.html(
$(this.$el.html()).attr("href", prefix + ":" + this.value)
);
$link.attr("href", prefix + this.value);
}
},
});
Expand Down
Loading