-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[15.0][MIG] web_form_banner: Migration to 15.0 #3287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 15.0
Are you sure you want to change the base?
Conversation
1e78c6b
to
eca678a
Compare
eca678a
to
12c8d30
Compare
f7a2d00
to
2ddbd7e
Compare
2ddbd7e
to
8f636ba
Compare
28f0455
to
5e9cbdf
Compare
@AungKoKoLin1997 Please confirm my commits and sort out the commit history. I think my changes can be squashed into the migration commit but comment the changed points. |
@AungKoKoLin1997 Can you also please switch the archive box icon to the banner? ![]() |
d3c42d1
to
c58a869
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and functional test.
Refactor JS: - Switch to the ESM style - Change var to const/let - Remove unused parts (diff, el.dataset.wfbTriggerFields) Miscellaneous improvements: - list view optional - Switch archive box icon to banner Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
c58a869
to
08d20a8
Compare
Based on #3286
@qrtl QT5747