Skip to content

Conversation

AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Sep 16, 2025

Based on #3286
@qrtl QT5747

@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review September 17, 2025 02:59
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as draft September 22, 2025 06:03
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-mig-web_form_banner branch 2 times, most recently from f7a2d00 to 2ddbd7e Compare September 22, 2025 07:32
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review September 22, 2025 07:33
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as draft September 22, 2025 07:33
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review September 22, 2025 09:42
@yostashiro yostashiro force-pushed the 15.0-mig-web_form_banner branch 2 times, most recently from 28f0455 to 5e9cbdf Compare September 23, 2025 10:18
@yostashiro
Copy link
Member

@AungKoKoLin1997 Please confirm my commits and sort out the commit history. I think my changes can be squashed into the migration commit but comment the changed points.

@yostashiro
Copy link
Member

@AungKoKoLin1997 Can you also please switch the archive box icon to the banner?

image

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-mig-web_form_banner branch 2 times, most recently from d3c42d1 to c58a869 Compare September 25, 2025 01:49
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test.

Refactor JS:
- Switch to the ESM style
- Change var to const/let
- Remove unused parts (diff, el.dataset.wfbTriggerFields)

Miscellaneous improvements:
- list view optional
- Switch archive box icon to banner

Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants