Skip to content

[18.0][FIX] Add !default to all color variable definitions #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][FIX] Add !default to all color variable definitions #3294

wants to merge 1 commit into from
+5 −5

Conversation

ljmnoonan
Copy link

This will allow web_dark_mode or any other theme to override colors defined here.
This is especially necessary for the $input-background-color-required variable because it looks hideous in a dark theme as mentioned by mathben in #3267

image

@legalsylvain

@ljmnoonan
[18.0][FIX] Add !default to all color variable definitions
5b3f470 
This will allow web_dark_mode to override them with its own colors.
@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@DavidJForgeFlow DavidJForgeFlow DavidJForgeFlow approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljmnoonan @OCA-git-bot @DavidJForgeFlow